fix: support regex_uri with unsafe_uri in proxy-rewrite#9813
Merged
juststillthinking merged 6 commits intoJul 14, 2023
Conversation
Signed-off-by: revolyssup <[email protected]>
5 tasks
Signed-off-by: revolyssup <[email protected]>
Contributor
|
Please fix the code lint |
juststillthinking
added
the
wait for update
Signed-off-by: revolyssup <[email protected]>
Contributor
Author
@monkeyDluffy6017 Done. Please approve CI |
Sn0rt
approved these changes
Jul 12, 2023
Comment on lines
+353
to
+363
| if conf.use_real_request_uri_unsafe and conf.regex_uri then | ||
| local index | ||
| if separator_escaped then | ||
| index = str_find(upstream_uri,"?") | ||
| end | ||
| if index then | ||
| upstream_uri = sub_str(upstream_uri, 1, index - 1) | ||
| ..sub_str(upstream_uri,index) | ||
| end | ||
| ctx.var.upstream_uri = upstream_uri | ||
| end |
Contributor
There was a problem hiding this comment.
Why do you add these code?
Contributor
Author
There was a problem hiding this comment.
You're right, in the if block above this when the safe encoding was on then this logic was added to first remove the ? and then readd after safely encoding. When we're skipping the safe encoding then we don't need to do any of that but I added it by mistake. Removed this.
Signed-off-by: revolyssup <[email protected]>
AlinsRan
previously approved these changes
Jul 14, 2023
juststillthinking
approved these changes
Jul 14, 2023
juststillthinking
suggested changes
Jul 14, 2023
juststillthinking
left a comment
juststillthinking
left a comment
Contributor
There was a problem hiding this comment.
Please add blank around the new code block
Signed-off-by: Ashish Tiwari <[email protected]>
…x into revolyssup/fixunsafebug
Contributor
Author
done |
juststillthinking
approved these changes
Jul 14, 2023
juststillthinking
added
approved
and removed
wait for update
AlinsRan
approved these changes
Jul 14, 2023
membphis
added a commit
that referenced
this pull request
May 12, 2026
… levels in v3.x sections (#13360) - Replace `## Doc improvements` (3.13.0 / 3.14.0 / 3.14.1) and `## Developer productivity` (3.13.0) with H3 so they nest under the release header instead of starting a new top-level section. - 3.12.0: correct OpenResty version typo `v1.27.11` -> `1.27.1.1` (#11936). - 3.11.0: fix plugin name typo `attach-consmer-label` -> `attach-consumer-label` (#11604). - 3.5.0: the `google-cloud-logging` `client_email` entry referenced #9813 (proxy-rewrite); the actual PR is #9622. - 3.0.0: fix `APSISIX` typo in the `enable_cpu_affinity` entry. Refs #13359.
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
… levels in v3.x sections (apache#13360) - Replace `## Doc improvements` (3.13.0 / 3.14.0 / 3.14.1) and `## Developer productivity` (3.13.0) with H3 so they nest under the release header instead of starting a new top-level section. - 3.12.0: correct OpenResty version typo `v1.27.11` -> `1.27.1.1` (apache#11936). - 3.11.0: fix plugin name typo `attach-consmer-label` -> `attach-consumer-label` (apache#11604). - 3.5.0: the `google-cloud-logging` `client_email` entry referenced apache#9813 (proxy-rewrite); the actual PR is apache#9622. - 3.0.0: fix `APSISIX` typo in the `enable_cpu_affinity` entry. Refs apache#13359.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9638
Tests to be added
Checklist