Skip to content

feat: add dubbo protocols support for xrpc #9660

Merged
juststillthinking merged 35 commits into
apache:masterfrom
wxbty:feature_dubbo_protocol
Sep 13, 2023
Merged

feat: add dubbo protocols support for xrpc #9660
juststillthinking merged 35 commits into
apache:masterfrom
wxbty:feature_dubbo_protocol

Conversation

@wxbty

@wxbty wxbty commented Jun 14, 2023

Copy link
Copy Markdown
Member

Description

Add dubbo protocol extension to apisix

Fixes #8352

@wxbty wxbty changed the title feature: add dubbo protocols support for xrpc feat: add dubbo protocols support for xrpc Jun 14, 2023
@juststillthinking

juststillthinking commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

@nic-chen please help to check this

@nic-chen

nic-chen commented Jun 15, 2023

Copy link
Copy Markdown
Member

hi @wxbty

Thank you for your PR.

Please add tests for the newly added features first, let's make sure the code works. Thanks !

@wxbty

wxbty commented Jul 5, 2023

Copy link
Copy Markdown
Member Author

@nic-chen added

nic-chen
nic-chen reviewed Jul 9, 2023
View reviewed changes
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua Outdated
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua Outdated
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua Outdated
Comment thread t/xrpc/dubbo.t
Comment thread t/xrpc/dubbo.t Outdated
@nic-chen

nic-chen commented Jul 14, 2023

Copy link
Copy Markdown
Member

hi @wxbty CI failed, please have a look

@wxbty

wxbty commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

ok, deal with it later

@wxbty

wxbty commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

hi @wxbty CI failed, please have a look
Thanks for your review, have added several testcases, but how to trigger ci again?

@Yilialinn

Yilialinn commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Hello, @wxbty
On behalf of the APISIX community, I‘d like to invite you to write an article introducing the background and design thinking behind this PR. May I have your contact information for further discussion? Thanks in advance!

@wxbty

wxbty commented Jul 17, 2023

Copy link
Copy Markdown
Member Author

Happy to discuss with you, wechat: wxb_101

@wxbty
wxbty requested a review from nic-chen July 17, 2023 02:48
@Sn0rt Sn0rt mentioned this pull request Jul 18, 2023
Closed
nic-chen
nic-chen reviewed Jul 18, 2023
View reviewed changes
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua
Comment thread apisix/stream/xrpc/protocols/dubbo/init.lua Outdated
Comment thread apisix/stream/xrpc/protocols/dubbo/metrics.lua
juststillthinking
juststillthinking reviewed Aug 7, 2023
View reviewed changes
Comment thread t/xrpc/dubbo.t Outdated
@juststillthinking

juststillthinking commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Could you merge the master branch?

@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Aug 7, 2023
AlinsRan
AlinsRan requested changes Aug 8, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
echo "Linux launch services, done."
- name: Start Dubbo Backend
if: matrix.os_name == 'linux_openresty' && steps.test_env.outputs.type == 'plugin'
if: matrix.os_name == 'linux_openresty' && [steps.test_env.outputs.type == 'plugin' || steps.test_env.outputs.type == 'xrpc']

@AlinsRan AlinsRan Aug 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/apisix/actions/runs/5751049180
Incorrect expression caused the CI to be skipped, please fix it.

@wxbty

wxbty commented Aug 8, 2023

Copy link
Copy Markdown
Member Author

Could you merge the master branch?

ok

juststillthinking
juststillthinking reviewed Aug 8, 2023
View reviewed changes
Comment thread t/xrpc/dubbo.t Outdated
@wxbty

wxbty commented Sep 5, 2023

Copy link
Copy Markdown
Member Author

@monkeyDluffy6017 PTAL

@juststillthinking

juststillthinking commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

@wxbty ok, i will check this later

@juststillthinking juststillthinking added approved and removed wait for update wait for the author's response in this issue/PR user responded labels Sep 13, 2023
@juststillthinking
juststillthinking merged commit 3578fbe into apache:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nic-chen nic-chen nic-chen approved these changes
@AlinsRan AlinsRan AlinsRan approved these changes
@kingluo kingluo Awaiting requested review from kingluo
@leslie-tsang leslie-tsang Awaiting requested review from leslie-tsang
+2 more reviewers
@Sn0rt Sn0rt Sn0rt left review comments
@juststillthinking juststillthinking juststillthinking approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

⚡️ Apache APISIX Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Directly support dubbo protocol proxy forwarding

6 participants

@wxbty @juststillthinking @nic-chen @Yilialinn @Sn0rt @AlinsRan