Skip to content

fix: get the correct revision#9635

Merged
juststillthinking merged 1 commit into
apache:masterfrom
syinwu:master
Jun 25, 2023
Merged

fix: get the correct revision#9635
juststillthinking merged 1 commit into
apache:masterfrom
syinwu:master

Conversation

@syinwu

@syinwu syinwu commented Jun 10, 2023

Copy link
Copy Markdown

Description

Fixes using incorrect revision when loading full data without loaded_configuration

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

@Bxlxx please provide an elaborate description.

@juststillthinking

Copy link
Copy Markdown
Contributor

@kingluo please help to check this

@juststillthinking

Copy link
Copy Markdown
Contributor

Test cases are needed

@kingluo

kingluo commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

@Bxlxx Yes, it's a bug. Thanks for your bugfix.

kingluo
kingluo previously approved these changes Jun 15, 2023
@juststillthinking
juststillthinking merged commit fc5ae82 into apache:master Jun 25, 2023
hongbinhsu added a commit to fitphp/apix that referenced this pull request Jul 8, 2023
* upstream/master: (70 commits)
  fix(workflow): enhance schema check (apache#9782)
  docs: add chinese documentation for loki-logger (apache#9687)
  chore(update): stand-alone text (apache#9736)
  docs: add Secret chinese document to Admin API (apache#9522)
  fix(log-rotate): can not keep max files when using custom name (apache#9749)
  docs: fix typo and added useful information (apache#8900)
  docs: explain in more details for the batch-requests plugin (apache#9629)
  docs: update `apisix` section in `config-default.yaml` (apache#9611)
  chore: add missing `report_interval` option for `skywalking` plugin in `config-default.yaml` (apache#9662)
  refactor(jwt-auth): remove unused parameter (apache#9716)
  change(request-id): remove snowflake algorithm (apache#9715)
  fix test case (apache#9706)
  docs: add correct link for openresty arm64 repo (apache#9713)
  fix: get the correct revision (apache#9635)
  fix(body-transformer): xml2lua: replace empty table with empty string (apache#9669)
  feat(prometheus): allow user configure DEFAULT_BUCKETS (apache#9673)
  docs: add example for timeout (apache#9708)
  docs: replace some urls that point to github with relative paths (apache#9684)
  docs: update Debian Installation Guide (apache#9680)
  docs: update how to install apisix on debian (apache#9693)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants