fix: wrong log format for splunk-hec-logging#9478
Merged
juststillthinking merged 7 commits intoMay 19, 2023
Merged
Conversation
Contributor
|
@Sn0rt please help to review |
Sn0rt
reviewed
May 16, 2023
| plugins = { | ||
| ["splunk-hec-logging"] = { | ||
| endpoint = { | ||
| uri = "http://127.0.0.1:18088/services/collector", |
Contributor
There was a problem hiding this comment.
where is the backend server ?
Contributor
There was a problem hiding this comment.
apisix/ci/pod/docker-compose.plugin.yml
Line 195 in 1e31e9d
Sn0rt
previously approved these changes
May 17, 2023
juststillthinking
changed the title
juststillthinking
previously approved these changes
May 17, 2023
Contributor
|
The real test cases are needed and i see an issue has been created: #9489. |
Contributor
|
Hi @jiangfucheng, It looks like that some ci failed because of your commit, please fix the ci error |
jiangfucheng
dismissed stale reviews from juststillthinking and Sn0rt
via
May 17, 2023 13:21
937949a
Member
Author
Fixed, thx. |
juststillthinking
approved these changes
May 17, 2023
Contributor
|
@leslie-tsang pls help review. |
Sn0rt
approved these changes
May 18, 2023
Sn0rt
approved these changes
May 19, 2023
soulbird
approved these changes
May 19, 2023
leslie-tsang
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9458
Checklist