Skip to content

fix(http-logger): default request path should be '/'#9472

Merged
juststillthinking merged 2 commits into
apache:masterfrom
jiangfucheng:http_logger
May 24, 2023
Merged

fix(http-logger): default request path should be '/'#9472
juststillthinking merged 2 commits into
apache:masterfrom
jiangfucheng:http_logger

Conversation

@jiangfucheng

Copy link
Copy Markdown
Member

Description

Fixes #9443

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird

Copy link
Copy Markdown
Contributor

@jiangfucheng

Copy link
Copy Markdown
Member Author

Look at this: https://github.com/api7/lua-resty-http/blob/master/t/13-default-path.t#L27, the default path is /

Thanks for you comment, I roughly took a look, the reqeust() method does not seem to cover this situation, it only covered by request_uri() method.

@juststillthinking
juststillthinking merged commit 59b82e2 into apache:master May 24, 2023
AlinsRan pushed a commit to AlinsRan/apisix that referenced this pull request Jun 25, 2023
@jiangfucheng
jiangfucheng deleted the http_logger branch August 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: http-logger plugin gives 400 error while pushing the logs to HTTP server

5 participants