fix: add rust-check target to the makefile for deps pre-checking#9453
Merged
Conversation
OS: not considering windows
Contributor
|
LGTM, cc @bzp2010 @monkeyDluffy6017 |
juststillthinking
previously approved these changes
May 10, 2023
juststillthinking
changed the title
check-rust in Makefile to see if Rust is installed before installing depscheck-rust in Makefile to see if Rust is installed before installing deps
leslie-tsang
previously approved these changes
May 10, 2023
kingluo
previously approved these changes
May 10, 2023
Co-authored-by: leslie <[email protected]>
kayx23
dismissed stale reviews from kingluo, leslie-tsang, and juststillthinking
via
May 11, 2023 02:12
c29a1f2
Co-authored-by: leslie <[email protected]>
kingluo
previously approved these changes
May 11, 2023
leslie-tsang
previously approved these changes
May 11, 2023
kayx23
commented
May 11, 2023
leslie-tsang
approved these changes
May 12, 2023
kingluo
approved these changes
May 12, 2023
leslie-tsang
changed the title
check-rust in Makefile to see if Rust is installed before installing depsrust-check target to the makefile for deps pre-checking
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
May 13, 2023
* upstream/master: (42 commits) fix: add `rust-check` target to the makefile for deps pre-checking (apache#9453) test: remove duplicate `proto` unit test file and tweak test case title (apache#9445) feat: proxy-mirror add grpc and grpcs support (apache#9388) test: replace all httpbin upstream (apache#9452) fix: 404 error in ci test (apache#9447) fix: body-transformer plugin return raw body anytime (apache#9446) fix(ci): fips: ensure apisix compiles with openssl3 (apache#9427) chore(deps): bump actions/stale from 7 to 8 (apache#9159) chore(deps): bump actions/setup-node from 3.5.1 to 3.6.0 (apache#8625) chore(test): split the access log of apisix and test server (apache#8819) docs: fix grammar (apache#9395) fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (apache#9287) (apache#9298) docs: use shell instead of Python to configure protos resources (apache#9414) docs: add guide to authenticate websocket connections (apache#9369) docs: updated Stream Proxy doc (apache#9367) feat: proxy_rewrite support miltiple regex pattern matching (apache#9194) feat: route-level MTLS (apache#9322) ci: tcp logger with real logger server (apache#9392) fix: always parse domain when host is domain name (apache#9332) docs: CHANGELOG.md Chinese docs lint (apache#9411) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Following instruction in Building APISIX from source to build APISIX and encountered the following issue related to Rust not installed in the environment:
Issue was introduced by this PR about LDAP: #9037
PR Description
Updated Makefile to check if Rust is installed in the environment before installing other deps.
Local Tests
Doc Update
See here
Checklist