fix(skywalking-logger, error-log-logger): support $hostname in skywalking service_instance_name#9401
Merged
Conversation
Contributor
|
LGTM |
Contributor
|
It looks like just a pick from other branch: #7252 |
Contributor
Author
@monkeyDluffy6017 Oh yes, it is. But that branch wasn't merged to master so this issue still exists. |
juststillthinking
previously approved these changes
May 10, 2023
juststillthinking
changed the title
Sn0rt
previously approved these changes
May 18, 2023
juststillthinking
added
the
wait for update
shreemaan-abhishek
dismissed stale reviews from Sn0rt and juststillthinking
via
May 22, 2023 18:15
03c8ed3
juststillthinking
approved these changes
May 23, 2023
juststillthinking
added
approved
and removed
wait for update
soulbird
approved these changes
May 25, 2023
leslie-tsang
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7977
Checklist