docs: Corrected typos and grammatical errors#9216
Merged
Merged
Conversation
pottekkat
reviewed
Apr 4, 2023
| #### Specify the namespace | ||
|
|
||
| Example of routing a request with an URI of "/nacosWithNamespaceId/*" to a service which name, namespaceId "http://192.168.33.1:8848/nacos/v1/ns/instance/list?serviceName=APISIX-NACOS&namespaceId=test_ns" and use nacos discovery client in the registry: | ||
| Example of routing a request with an URI of "/nacosWithNamespaceId/*" to a service whose name, namespaceId "http://192.168.33.1:8848/nacos/v1/ns/instance/list?serviceName=APISIX-NACOS&namespaceId=test_ns" and use nacos discovery client in the registry: |
Member
There was a problem hiding this comment.
"with" might be better here and for other places with similar changes.
Member
There was a problem hiding this comment.
@Neilblaze Could you make this change throughout? I still see some uses of "whose".
Contributor
Author
There was a problem hiding this comment.
ah I see, okay I'll do it.
SylviaBABY
reviewed
Apr 4, 2023
| ### Configuring path forwarding | ||
|
|
||
| The `aws-lambda` Plugins also supports URL path forwarding while proxying requests to the AWS upstream. Extensions to the base request path gets appended to the `function_uri` specified in the Plugin configuration. | ||
| The `aws-lambda` Plugins also support URL path forwarding while proxying requests to the AWS upstream. Extensions to the base request path gets appended to the `function_uri` specified in the Plugin configuration. |
Member
There was a problem hiding this comment.
Suggested change
| The `aws-lambda` Plugins also support URL path forwarding while proxying requests to the AWS upstream. Extensions to the base request path gets appended to the `function_uri` specified in the Plugin configuration. | |
| The `aws-lambda` Plugin also supports URL path forwarding while proxying requests to the AWS upstream. Extensions to the base request path gets appended to the `function_uri` specified in the Plugin configuration. |
abs007
reviewed
Apr 4, 2023
| ``` | ||
|
|
||
| In some case, same service name exist in different consul servers. | ||
| In some case, same service name might exist in different consul servers. |
Signed-off-by: Pratyay Banerjee <[email protected]>
Neilblaze
force-pushed
the
docs-patch_typoFix
branch
from
April 5, 2023 11:45
a2fef42 to
65d025d
Compare
SylviaBABY
approved these changes
Apr 6, 2023
pottekkat
approved these changes
Apr 7, 2023
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Apr 11, 2023
* upstream/master: (25 commits) fix: upgrade lua-resty-ldap to 0.2.2 (apache#9254) feat(cli): support bypassing Admin API Auth by configuration (apache#9147) fix(ci): write version into xds first (apache#9274) fix: skip warning log when apisix.data_encryption.enable is false (apache#9057) docs: add-api7-information (apache#9260) docs: Fixed typo (apache#9244) docs: clarify what is client.ca in client-to-apisix-mtls.md (apache#9221) docs: Corrected typos and grammatical errors (apache#9216) docs: updated ssl sni parameter requirement in admin-api.md (apache#9176) fix: check upstream reference in traffic-split plugin when delete upstream (apache#9044) docs: Update proxy-rewrite headers.add docs (apache#9220) feat: suppot header injection for fault-injection plugin (apache#9039) fix: upgrade lua-resty-etcd to 1.10.4 (apache#9235) docs: fix incorrect semantic.yml link (apache#9231) feat: Upstream status report (apache#9151) fix: host_hdr should not be false (apache#9150) docs: remove APISIX base instruction (apache#9117) fix(cli): prevent non-`127.0.0.0/24` to access admin api with empty admin_key (apache#9146) docs: fix 404 link (apache#9160) fix(cors): consider using `allow_origins_by_regex` only when it is not `nil` (apache#9028) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few typos and grammatical errors were discovered and have been corrected.
Checklist
cc: @navendu-pottekkat, @juzhiyuan, @SylviaBABY