feat: limit-count plugin supports username and ssl for redis policy#9185
Merged
Conversation
Contributor
|
Hi @simon-flury, Test cases are needed |
Contributor
Author
|
Hi @monkeyDluffy6017, i add tests, thks |
Contributor
|
@soulbird @leslie-tsang @kingluo please help to review this PR |
juststillthinking
approved these changes
Apr 18, 2023
| ssl_verify = conf.redis_ssl_verify | ||
| } | ||
|
|
||
| local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379, sock_opts) |
Member
There was a problem hiding this comment.
Suggested change
| local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379, sock_opts) | |
| local ok, err = red:connect(conf.redis_host, conf.redis_port, sock_opts) |
It seems that we don't need a default value because it is already defined in the schema.
kingluo
approved these changes
Apr 20, 2023
leslie-tsang
approved these changes
Apr 20, 2023
Contributor
Author
|
Hi @Qizeng-api7, i add my email address on my GitHub page. Thank you,
Simon Flury
***@***.***
Envoyé avec la messagerie sécurisée Proton Mail.
…------- Original Message -------
Le mercredi 26 avril 2023 à 10:01, Qizeng-api7 ***@***.***> a écrit :
Hello, @simon-flury! I am the operator of the APISIX Community. Thank you for your contribution to Apache APISIX! To express our gratitude and encouragement for your contribution, the Apache APISIX community would like to present to you the APISIX Contributor Certificate! However, we couldn't find your email address on your GitHub page, would you mind letting us know? We will send you a digital certificate by email later as a token of our appreciation.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.[https://mail.proton.me/api/core/v4/images?Url=https%3A%2F%2Fgithub.com%2Fnotifications%2Fbeacon%2FAEKJPKKGH76M75FHUNAYQX3XDDI5PA5CNFSM6AAAAAAWKZDA7SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS2Y2CXW.gif&DryRun=0&UID=p4z4t3ldgjww2pma6xgtunmusnimrged]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to use username and SSL to connect the plugin limit-count to a Redis instance with policy 'Redis'.
Fixes #9175
Checklist