fix: checker leak for domain nodes#9090
Merged
Merged
Conversation
kingluo
marked this pull request as ready for review
March 16, 2023 09:13
spacewander
reviewed
Mar 17, 2023
spacewander
left a comment
Member
There was a problem hiding this comment.
Let's merge master to make CI pass.
| apisix = require("apisix") | ||
| core = require("apisix.core") | ||
| apisix.http_init() | ||
|
|
Member
There was a problem hiding this comment.
We can use the new extra_init_by_lua so the lines above are not needed.
kingluo
force-pushed
the
bugfix_checker_leak
branch
from
March 20, 2023 06:21
de388b0 to
a77902f
Compare
spacewander
approved these changes
Mar 20, 2023
soulbird
approved these changes
Mar 20, 2023
AlinsRan
pushed a commit
to AlinsRan/apisix
that referenced
this pull request
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8932
Only
route.value.upstream.parenthas table reference toroute, so skip it indeepcopyto fix this bug and also avoid a recursive copy (27c37b1).Checklist