feat: add ldap-auth-advanced plugin#9022
Closed
bzp2010 wants to merge 13 commits into
Closed
Conversation
5 tasks
bzp2010
marked this pull request as ready for review
March 23, 2023 15:23
Contributor
|
Missing doc？ |
soulbird
reviewed
Mar 24, 2023
| return nil, err | ||
| end | ||
|
|
||
| if not m then |
Contributor
There was a problem hiding this comment.
These two judgments can be combined
| end | ||
|
|
||
|
|
||
| local function extract_auth_header(authorization) |
Contributor
There was a problem hiding this comment.
This function is used multiple times in different plugins, can we put them in a unified location. Maybe record a todo
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the Proposal in #8958, this PR implements a new LDAP authentication plugin that is more standardized and flexible.
New #8958
Checklist