feat: stream subsystem support tars service discovery#8826
Merged
spacewander merged 1 commit intoFeb 17, 2023
Conversation
Signed-off-by: ashing <[email protected]>
ronething
marked this pull request as ready for review
February 10, 2023 08:16
spacewander
reviewed
Feb 14, 2023
| schema.properties.full_fetch_interval.default = 3 | ||
| _EOC_ | ||
|
|
||
| $block->set_value("extra_init_by_lua_start", $extra_init_by_lua_start); |
Member
There was a problem hiding this comment.
Why do we need to set the HTTP version in the stream test?
Member
Author
There was a problem hiding this comment.
The discovery configuration will affect both the HTTP and steam subsystem simultaneously. If we do not set extra_init_by_lua_start in HTTP, it will cause error like below.
nginx: [error] init_by_lua error: .../apisix/apisix/core/config_local.lua:71: invalid discovery tars configuration: property "full_fetch_interval" validation failed: expected 3 to be at least 90
spacewander
approved these changes
Feb 15, 2023
Member
Author
|
@soulbird Could you please take a look, thanks. |
soulbird
approved these changes
Feb 17, 2023
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Feb 23, 2023
* upstream/master: fix: limit count plugin conf parameter undefined error (apache#8902) chore: remove duplicate kubernetes test case (apache#8882) feat: add 'range_id' algorithm for 'request-id' plugin (apache#8790) chore(error-log-logger): add kafka meta_refresh_interval (apache#8821) chore(deps): bump golang.org/x/net from 0.2.0 to 0.7.0 in /t/grpc_server_example (apache#8881) docs: Update getting-started.md (apache#8763) fix(admin): fix wrong http code for patch method (apache#8855) feat: stream subsystem support tars service discovery (apache#8826) feat(ci): implement image caching to reduce ci build time. (apache#8735) feat(admin): add head method support to /apisix/admin (apache#8752) feat: opentelemetry plugin config collector.address support specify https scheme (apache#8823) fix: add admin schema to control_plane config (apache#8809)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashing [email protected]
Description
Fixes #7779
add tars service discovery, and it is the last PR for service discovery in the stream subsystem
for test case, i add
stream_extra_init_by_lua_startto fileAPISIX.pm.some code inspired by PR: #8640
Checklist