fix: invalidate cache in core.request.add_haeder and fix some calls#8824
Merged
Conversation
tokers
reviewed
Feb 10, 2023
jiangfucheng
force-pushed
the
fix_8811
branch
3 times, most recently
from
February 13, 2023 14:15
d5296c5 to
9e193e4
Compare
Member
Author
|
|
soulbird
reviewed
Feb 15, 2023
jiangfucheng
force-pushed
the
fix_8811
branch
2 times, most recently
from
February 16, 2023 14:02
6409042 to
93aa57c
Compare
Member
Author
|
@soulbird @spacewander @tokers PTAL, Thanks. |
tokers
reviewed
Feb 17, 2023
soulbird
previously approved these changes
Feb 21, 2023
spacewander
reviewed
Feb 21, 2023
| end | ||
|
|
||
| function _M.add_header(header_name, header_value) | ||
| function _M.add_header(ctx, header_name, header_value) |
Member
There was a problem hiding this comment.
Yes, we can refactor it and take the common part out.
spacewander
reviewed
Feb 21, 2023
jiangfucheng
force-pushed
the
fix_8811
branch
3 times, most recently
from
February 21, 2023 15:50
d805c63 to
c034826
Compare
jiangfucheng
force-pushed
the
fix_8811
branch
from
February 22, 2023 00:35
c034826 to
01a1743
Compare
jiangfucheng
force-pushed
the
fix_8811
branch
2 times, most recently
from
February 22, 2023 14:03
4fa64eb to
eed28bb
Compare
jiangfucheng
requested review from
soulbird and
spacewander
and removed request for
spacewander
February 24, 2023 03:45
jiangfucheng
force-pushed
the
fix_8811
branch
from
February 25, 2023 07:04
eed28bb to
b420294
Compare
Member
Author
|
@spacewander @monkeyDluffy6017 @soulbird Please help me review this PR again, thanks❤️. |
spacewander
reviewed
Feb 27, 2023
soulbird
reviewed
Feb 28, 2023
soulbird
reviewed
Mar 1, 2023
soulbird
previously approved these changes
Mar 1, 2023
spacewander
reviewed
Mar 2, 2023
spacewander
approved these changes
Mar 10, 2023
juststillthinking
approved these changes
Mar 10, 2023
soulbird
approved these changes
Mar 12, 2023
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Mar 17, 2023
* upstream/master: (46 commits) fix(consumer): work if the etcd connection failed during starting (apache#9077) ci: fix low disk space error when loading saved docker images (apache#9080) change: change the default router from radixtree uri to radixtree hos… (apache#9047) chore(deps): bump dubbo from 2.7.18 to 2.7.21 in /t/lib/dubbo-backend/dubbo-backend-provider (apache#9041) fix: cli test on master (apache#9075) fix: Non wildcard origin in CORS should sent Vary header (apache#9010) feat: bump lua-resty-ldap version for ldap-auth (apache#9037) fix: invalidate cache in core.request.add_haeder and fix some calls (apache#8824) docs: remove unnecessary getting-started.md (apache#9054) docs: contribute Getting Started tutorials (apache#9046) docs: replace full-width quotation mark with half-width quotation mark (apache#8887) docs: fix typo and grammar (apache#9008) feat: ready to release 2.15.3 (apache#9021) ci: ensure the test can run with different repo name (apache#8832) chore(deps): bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 in /ci/pod/openfunction/function-example/test-uri (apache#9018) docs: improved SEO & fixed typo and localization issues (apache#8993) feat: release APISIX 3.2.0 (apache#8988) docs: fix grammar (apache#8935) docs: fix indent in encrypted-storage-fields (apache#8876) docs: k8s discovery: state the restriction on the use of port number (apache#8969) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8811
Checklist