Skip to content

feat: stream subsystem support nacos service discovery#8584

Merged
spacewander merged 6 commits into
apache:masterfrom
ronething:feat/stream_route_discovery_nacos
Jan 12, 2023
Merged

feat: stream subsystem support nacos service discovery#8584
spacewander merged 6 commits into
apache:masterfrom
ronething:feat/stream_route_discovery_nacos

Conversation

@ronething

@ronething ronething commented Dec 29, 2022

Copy link
Copy Markdown
Member

Description

Fixes #7779

because of nacos service discovery use resty.worker.events, so i add lua_shared_dict worker-events-stream to stream module.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@ronething
ronething marked this pull request as ready for review January 4, 2023 07:30
Comment thread t/discovery/stream/nacos.t Outdated
worker_connections(256);
no_root_location();
no_shuffle();
workers(1);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need multiple workers to test worker-event

Comment thread t/discovery/stream/nacos.t Outdated

if (!$block->stream_request) {
# GET /hello HTTP/1.1\r\nHost: 127.0.0.1:1985\r\nConnection: close\r\n\r\n
$block->set_value("stream_request", "\x47\x45\x54\x20\x2f\x68\x65\x6c\x6c\x6f\x20\x48\x54\x54\x50\x2f\x31\x2e\x31\x0d\x0a\x48\x6f\x73\x74\x3a\x20\x31\x32\x37\x2e\x30\x2e\x30\x2e\x31\x3a\x31\x39\x38\x35\x0d\x0a\x43\x6f\x6e\x6e\x65\x63\x74\x69\x6f\x6e\x3a\x20\x63\x6c\x6f\x73\x65\x0d\x0a\x0d\x0a");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it more clear. See #8593 (comment)

@ronething
ronething requested a review from spacewander January 5, 2023 08:11
@ronething

Copy link
Copy Markdown
Member Author

@tokers @soulbird Could you please take a look? thanks.

@spacewander
spacewander merged commit 9e3fd00 into apache:master Jan 12, 2023
@ronething
ronething deleted the feat/stream_route_discovery_nacos branch January 12, 2023 01:36
hongbinhsu added a commit to fitphp/apix that referenced this pull request Jan 30, 2023
* upstream/master: (67 commits)
  fix: grpc-transcode plugin: fix map data population (apache#8731)
  change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua (apache#8660)
  feat: stream subsystem support consul_kv service discovery (apache#8633)
  fix(proxy-mirror): use with uri rewrite (apache#8718)
  ci: move helper script to the right dir (apache#8691)
  refactor(pubsub): simpify the get_cmd implementation (apache#8608)
  feat: stream subsystem support kubernetes service discovery (apache#8640)
  docs: fix deployment links (apache#8714)
  fix: remove backslash before slash when encoding (apache#8684)
  ci: kafka should register port in the zookeeper same as exposed (apache#8672)
  docs: fix plugin config naming (apache#8701)
  docs: fix code block (apache#8700)
  docs: rename kms to secret (apache#8697)
  docs: replace transparent logos with white background logos (apache#8689)
  fix: upgrade lua-resty-etcd to 1.10.3 (apache#8668)
  fix: upgrade casbin to 1.41.3 to improve performance (apache#8676)
  chore: make send_stream_request more clear (apache#8627)
  feat: stream subsystem support nacos service discovery (apache#8584)
  feat: stream subsystem support dns service discovery (apache#8593)
  refactor(admin): refactor resource routes (apache#8611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to support service discovery in the stream subsystem

3 participants