Skip to content

refactor(makefile): add PCRE_INCDIR variable#8433

Merged
juststillthinking merged 7 commits into
apache:masterfrom
drgnchan:master
Apr 12, 2023
Merged

refactor(makefile): add PCRE_INCDIR variable#8433
juststillthinking merged 7 commits into
apache:masterfrom
drgnchan:master

Conversation

@drgnchan

@drgnchan drgnchan commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Description

Fixes #8432

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Comment thread Makefile Outdated
@drgnchan
drgnchan requested a review from tokers November 30, 2022 14:22
@drgnchan

Copy link
Copy Markdown
Contributor Author

I have tested with Linux and Darwin:

  1. rm -rf deps
  2. rm ~/.luarocks/config-5.1.lua
  3. rerun make deps

Finally both linux and darwin install jsonschema(requeir pcre) successfully.

@drgnchan

drgnchan commented Dec 1, 2022

Copy link
Copy Markdown
Contributor Author

I am not sure why the CI job build (ubuntu-20.04, linux_openresty_1_19, t/plugin/[a-k]*) succeeded but build (ubuntu-20.04, linux_openresty, t/plugin/[a-k]*) failed.And I think the difference of the two job is the openresty version.

@tzssangglass

Copy link
Copy Markdown
Member

the failed CI CI Centos7 / run ci on centos7 (t/node t/pubsub t/router t/script t/stream-node t/utils t/wasm t/xds-library) (pull_request) has been fixed by #8438, pls merge upstream master branch to your PR.

@tzssangglass

Copy link
Copy Markdown
Member

hi @drgnchan I think you are mistaken, your PR has other people's commits in it.

@tzssangglass

Copy link
Copy Markdown
Member

@drgnchan

drgnchan commented Dec 2, 2022

Copy link
Copy Markdown
Contributor Author

@tzssangglass I am sorry having made the wrong workflow before.I just sync fork by Github and I think it is ok now.

Comment thread Makefile
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@juststillthinking
juststillthinking merged commit a7e09e7 into apache:master Apr 12, 2023
@Sn0rt

Sn0rt commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

LGTM

the branch has been tested at a M2 machine.

@juststillthinking

Copy link
Copy Markdown
Contributor

@Sn0rt Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: for mac making deps,pcre header file cannot be found

6 participants