Skip to content

feat: add vault common components#8412

Merged
spacewander merged 9 commits into
apache:masterfrom
soulbird:feat/sm-kms-vault
Nov 28, 2022
Merged

feat: add vault common components#8412
spacewander merged 9 commits into
apache:masterfrom
soulbird:feat/sm-kms-vault

Conversation

@soulbird

@soulbird soulbird commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Description

As part of #8319:

Add vault common component. Currently only supporting the get operation is enough

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird
soulbird marked this pull request as ready for review November 28, 2022 05:57
@soulbird
soulbird requested review from spacewander and tzssangglass and removed request for spacewander November 28, 2022 06:33
#

# prepare vault kv engine
sleep 3s

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why sleep 3s here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the vault service has been started normally, this is just an experience value, it does work.

Comment thread .github/workflows/build.yml Outdated
Comment thread apisix/kms/vault.lua Outdated
Comment thread apisix/kms/vault.lua Outdated
@spacewander
spacewander merged commit d6b0487 into apache:master Nov 28, 2022
hongbinhsu added a commit to fitphp/apix that referenced this pull request Dec 4, 2022
* upstream/master: (48 commits)
  fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184)
  chore: add some comment for make_request_to_vault function (apache#8420)
  docs: update admin api English doc (apache#8227)
  ci: use fixed os version of ubuntu (apache#8438)
  feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421)
  feat: interact via gRPC in APISIX Admin API (apache#8411)
  fix: last_err can be nil when the reconnection is successful (apache#8377)
  feat: support global data encryption of secret information (apache#8403)
  refactor(env): rename funtion name (apache#8426)
  feat(admin): add kms admin api (apache#8394)
  docs: update consumer and upstream docs (apache#8223)
  ci: add cron job for GM (apache#8398)
  docs: add kms env doc (apache#8419)
  feat: Added log format support in syslog plugin. (apache#8279)
  feat: add vault common components (apache#8412)
  docs: update global-rule/plugin-config/plugin/ docs (apache#8262)
  docs: update consumer-group/router/service/script doc (apache#8332)
  feat: support store secret in env for auth plugin (apache#8390)
  docs: update Upgrade Guide CN version (apache#8392)
  docs: add GM plugin EN doc to make website display normally (apache#8393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants