feat: support global data encryption of secret information#8403
Merged
Conversation
Comment on lines
+44
to
+49
| for key, props in pairs(consumer_schema.properties) do | ||
| if props.type == "string" and props.encrypted then | ||
| local encrypted = apisix_ssl.aes_decrypt_pkey(conf[key], "global_data_encrypt") | ||
| conf[key] = encrypted | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
The schema may have nested objects
Member
Author
There was a problem hiding this comment.
I know that since this PR does not include this case, we can optimize this point in the next PR.
tzssangglass
marked this pull request as ready for review
November 28, 2022 11:37
membphis
reviewed
Nov 29, 2022
tzssangglass
commented
Nov 29, 2022
soulbird
reviewed
Nov 29, 2022
| return | ||
| end | ||
|
|
||
| for key, props in pairs(schema.properties) do |
Contributor
There was a problem hiding this comment.
Don't we consider the case of configuration nesting here?
Member
Author
There was a problem hiding this comment.
I know that since this PR does not include this case, we can optimize this point in the next PR.
Contributor
There was a problem hiding this comment.
It's better to notice this point at doc ?
Member
Author
There was a problem hiding this comment.
I don't think it's needed and will finish it soon.
Contributor
There was a problem hiding this comment.
It's a bit complicated, like 'anyof', 'oneof' need to be considered.
Member
Author
There was a problem hiding this comment.
Anyof or oneof only restricts the existence of items, if an item has encrypted = true but does not exist in conf, it will not be encrypted.
tzssangglass
requested review from
juststillthinking,
membphis and
soulbird
and removed request for
juststillthinking
November 29, 2022 10:27
spacewander
reviewed
Nov 29, 2022
tzssangglass
requested review from
spacewander
and removed request for
juststillthinking
November 29, 2022 14:33
spacewander
reviewed
Nov 30, 2022
soulbird
reviewed
Nov 30, 2022
soulbird
approved these changes
Nov 30, 2022
spacewander
approved these changes
Nov 30, 2022
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Dec 4, 2022
* upstream/master: (48 commits) fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184) chore: add some comment for make_request_to_vault function (apache#8420) docs: update admin api English doc (apache#8227) ci: use fixed os version of ubuntu (apache#8438) feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421) feat: interact via gRPC in APISIX Admin API (apache#8411) fix: last_err can be nil when the reconnection is successful (apache#8377) feat: support global data encryption of secret information (apache#8403) refactor(env): rename funtion name (apache#8426) feat(admin): add kms admin api (apache#8394) docs: update consumer and upstream docs (apache#8223) ci: add cron job for GM (apache#8398) docs: add kms env doc (apache#8419) feat: Added log format support in syslog plugin. (apache#8279) feat: add vault common components (apache#8412) docs: update global-rule/plugin-config/plugin/ docs (apache#8262) docs: update consumer-group/router/service/script doc (apache#8332) feat: support store secret in env for auth plugin (apache#8390) docs: update Upgrade Guide CN version (apache#8392) docs: add GM plugin EN doc to make website display normally (apache#8393) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8407
Checklist