feat: support store secret in env for auth plugin#8390
Merged
Conversation
soulbird
requested review from
membphis,
spacewander and
tzssangglass
and removed request for
spacewander and
tzssangglass
November 24, 2022 05:49
soulbird
marked this pull request as ready for review
November 24, 2022 05:59
spacewander
reviewed
Nov 24, 2022
| local function retrieve(refs) | ||
| log.info(string.format("retrieve secrets refs: %p", refs)) | ||
|
|
||
| local new_refs = table.clone(refs) |
Member
There was a problem hiding this comment.
Do we need to use deepcopy for the later recursive call?
Contributor
Author
There was a problem hiding this comment.
Actually I'm not sure, but it seems safer to use deepcopy.
spacewander
previously approved these changes
Nov 24, 2022
membphis
reviewed
Nov 24, 2022
spacewander
reviewed
Nov 25, 2022
tokers
reviewed
Nov 25, 2022
spacewander
previously approved these changes
Nov 25, 2022
tokers
approved these changes
Nov 25, 2022
tzssangglass
approved these changes
Nov 25, 2022
spacewander
approved these changes
Nov 25, 2022
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Dec 4, 2022
* upstream/master: (48 commits) fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184) chore: add some comment for make_request_to_vault function (apache#8420) docs: update admin api English doc (apache#8227) ci: use fixed os version of ubuntu (apache#8438) feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421) feat: interact via gRPC in APISIX Admin API (apache#8411) fix: last_err can be nil when the reconnection is successful (apache#8377) feat: support global data encryption of secret information (apache#8403) refactor(env): rename funtion name (apache#8426) feat(admin): add kms admin api (apache#8394) docs: update consumer and upstream docs (apache#8223) ci: add cron job for GM (apache#8398) docs: add kms env doc (apache#8419) feat: Added log format support in syslog plugin. (apache#8279) feat: add vault common components (apache#8412) docs: update global-rule/plugin-config/plugin/ docs (apache#8262) docs: update consumer-group/router/service/script doc (apache#8332) feat: support store secret in env for auth plugin (apache#8390) docs: update Upgrade Guide CN version (apache#8392) docs: add GM plugin EN doc to make website display normally (apache#8393) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of #8319:
Step 1: Support the use of environment variables to manage keys. Information in the consumer configuration is more private, so we first used environment variables in the consumer to manage sensitive information.
Currently only test cases have been added for the key-auth plugin, the test cases for other plugins will be completed in a separate PR.
Checklist