fix(log-rotate): max_kept works on compression files#8366
Merged
Conversation
tzssangglass
marked this pull request as ready for review
November 21, 2022 07:57
juststillthinking
previously approved these changes
Nov 22, 2022
soulbird
reviewed
Nov 22, 2022
soulbird
approved these changes
Nov 22, 2022
juststillthinking
approved these changes
Nov 22, 2022
spacewander
approved these changes
Nov 22, 2022
| count = count + 1 | ||
| end | ||
| end | ||
| --- only two compression file, access.log.tar.gz and error.log.tar.gz |
Member
There was a problem hiding this comment.
The compression file should be named with a timestamp?
Member
Author
There was a problem hiding this comment.
The compression file should be named with a timestamp?
The names of the compressed files actually contain timestamps, like 2022-11-22_16-50-37__access.log.tar.gz, 2022-11-22_16-50-38__error.log.tar.gz, the comment is just to indicate that only two (timestamped) compressed files remain in this test condition.
starsz
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8343
Checklist