fix(ai): remove BUILD_ROUTER event when ai module is unloaded#8184
Merged
Conversation
added 9 commits
October 27, 2022 11:00
soulbird
marked this pull request as ready for review
October 27, 2022 14:18
spacewander
reviewed
Oct 28, 2022
spacewander
left a comment
spacewander
left a comment
Member
There was a problem hiding this comment.
Can we remove the TODO now?
Line 299 in 48b8431
soulbird
marked this pull request as draft
October 28, 2022 06:51
membphis
requested changes
Oct 28, 2022
added 3 commits
November 2, 2022 21:55
soulbird
marked this pull request as ready for review
November 3, 2022 01:06
spacewander
previously approved these changes
Nov 3, 2022
tzssangglass
previously approved these changes
Nov 3, 2022
soulbird
dismissed stale reviews from tzssangglass and spacewander
via
November 7, 2022 02:42
bcd5053
Contributor
Author
|
@membphis review pls |
tzssangglass
approved these changes
Nov 9, 2022
membphis
approved these changes
Dec 2, 2022
Member
|
@soulbird pls merge this PR soon ^_^ |
spacewander
approved these changes
Dec 2, 2022
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Dec 4, 2022
* upstream/master: (48 commits) fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184) chore: add some comment for make_request_to_vault function (apache#8420) docs: update admin api English doc (apache#8227) ci: use fixed os version of ubuntu (apache#8438) feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421) feat: interact via gRPC in APISIX Admin API (apache#8411) fix: last_err can be nil when the reconnection is successful (apache#8377) feat: support global data encryption of secret information (apache#8403) refactor(env): rename funtion name (apache#8426) feat(admin): add kms admin api (apache#8394) docs: update consumer and upstream docs (apache#8223) ci: add cron job for GM (apache#8398) docs: add kms env doc (apache#8419) feat: Added log format support in syslog plugin. (apache#8279) feat: add vault common components (apache#8412) docs: update global-rule/plugin-config/plugin/ docs (apache#8262) docs: update consumer-group/router/service/script doc (apache#8332) feat: support store secret in env for auth plugin (apache#8390) docs: update Upgrade Guide CN version (apache#8392) docs: add GM plugin EN doc to make website display normally (apache#8393) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist