feat: add dafault value roundrobin for upstream_schema#8180
Merged
Conversation
Hazel6869
marked this pull request as draft
October 26, 2022 07:34
Member
|
we need to update test cases and docs |
Contributor
Author
ok i will do it |
Hazel6869
marked this pull request as ready for review
October 27, 2022 09:36
Hazel6869
marked this pull request as draft
October 27, 2022 09:36
Hazel6869
marked this pull request as ready for review
October 27, 2022 09:45
5 tasks
spacewander
reviewed
Oct 28, 2022
| "nodes": { | ||
| "127.0.0.1:8080": 1 | ||
| } | ||
| }]] |
Member
There was a problem hiding this comment.
Better to check the default value of type like
Line 46 in 48b8431
Member
|
Do we need to remove a lot of |
spacewander
reviewed
Oct 30, 2022
| ngx.say(body) | ||
|
|
||
| local res = assert(etcd.get('/upstreams/admin_up')) | ||
| local create_time = res.body.node.value.create_time |
Member
There was a problem hiding this comment.
We don't need to check xxx_time, right?
Contributor
Author
There was a problem hiding this comment.
Right, I have fixed it.
Member
Yes, let's do it with script. |
tzssangglass
approved these changes
Oct 31, 2022
spacewander
reviewed
Nov 1, 2022
| type = { | ||
| description = "algorithms of load balancing", | ||
| type = "string", | ||
| default = "roundrobin", |
Member
There was a problem hiding this comment.
Do we need to update the doc too?
Contributor
Author
There was a problem hiding this comment.
I have done. pls see description. @spacewander @tokers
Member
There was a problem hiding this comment.
Could you please put the doc in the same PR next time?
So people don't need to check another one.
tokers
approved these changes
Nov 2, 2022
soulbird
approved these changes
Nov 2, 2022
spacewander
approved these changes
Nov 2, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Nov 7, 2022
* upstream/master: (94 commits) test: add test cases for ai module (apache#8222) fix(ai): typo key name (apache#8232) docs: update the docs of admin API (apache#8191) Update standalone docs for change in SSL parameter (apache#8242) fix: can not modify x-forwarded-host in proxy rewrite (apache#8200) chore: export the set cert/key process so we can hook it (apache#8228) test: add cases of ai module (apache#8214) feat: add dafault value roundrobin for upstream_schema (apache#8180) docs: update limit plugin docs (apache#8154) dix remote_addr (apache#8210) fix(zipkin): send trace IDs with a reject sampling decision (apache#8099) docs: update hmac-auth doc (apache#8192) docs: update limit count plugin doc (apache#8196) docs: fix building apisix misled (apache#8189) fix: meta.filter in plugin doesn't work in response-rewrite plugin (apache#8162) feat: release 3.0 (apache#8179) docs: refactor admin api doc (apache#8145) docs: refactor health check doc (apache#8129) docs: protect-api.md typo, remove redundant braces. (apache#8139) feat: renew route lrucache when the routes change (apache#8157) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8114
the docs pr #8191
Checklist