Skip to content

docs: update redirect doc#8051

Merged
spacewander merged 4 commits into
apache:masterfrom
Hazel6869:feature_redirect_doc
Oct 17, 2022
Merged

docs: update redirect doc#8051
spacewander merged 4 commits into
apache:masterfrom
Hazel6869:feature_redirect_doc

Conversation

@Hazel6869

@Hazel6869 Hazel6869 commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Description

we can't get find the way that we can configure the redirect to a url like this https://apisix.apache.org/docs. But in fact, we support it, it will mislead users that we don't support it, so i resolve it.

Fixes #7945

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Hazel6869
Hazel6869 marked this pull request as draft October 9, 2022 06:26
@Hazel6869
Hazel6869 marked this pull request as ready for review October 9, 2022 07:59
tzssangglass
tzssangglass previously approved these changes Oct 9, 2022
SylviaBABY
SylviaBABY previously approved these changes Oct 10, 2022
@spacewander

Copy link
Copy Markdown
Member

screenshot-20221011-172507
Bad number?

@Hazel6869

Hazel6869 commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

screenshot-20221011-172507 Bad number?
@spacewander
Why bad number, i can access it.

@spacewander

Copy link
Copy Markdown
Member

It should be Fix #7945

@Hazel6869

Copy link
Copy Markdown
Contributor Author

It should be Fix #7945

thanks your suggestion, i have fix it.

@spacewander

Copy link
Copy Markdown
Member

Still have two # between Fix and the ID.

@Hazel6869

Copy link
Copy Markdown
Contributor Author

Still have two # between Fix and the ID.
sorry 😫 , have changed.

spacewander
spacewander previously approved these changes Oct 14, 2022
Comment thread docs/zh/latest/plugins/redirect.md Outdated
Comment thread docs/en/latest/plugins/redirect.md Outdated
@tzssangglass

Copy link
Copy Markdown
Member

@Hazel6869 pls fix conflicts

@Hazel6869

Copy link
Copy Markdown
Contributor Author

@Hazel6869 pls fix conflicts

has done, thanks

@tzssangglass tzssangglass changed the title feat: update redirect doc docs: update redirect doc Oct 17, 2022
@spacewander
spacewander merged commit 1151d32 into apache:master Oct 17, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: we can configure the uri field in redirect plugin with the host

5 participants