feat: add workflow plugin(mvp)#7760
Merged
Merged
Conversation
tzssangglass
marked this pull request as ready for review
August 23, 2022 07:43
soulbird
reviewed
Aug 23, 2022
spacewander
reviewed
Aug 23, 2022
5 tasks
spacewander
approved these changes
Aug 23, 2022
|
|
||
|
|
||
| local function exit(conf) | ||
| local code = tonumber(conf.code) |
Member
There was a problem hiding this comment.
Is tonumber necessary after the schema check?
Member
Author
There was a problem hiding this comment.
no need, fix it on next PR.
soulbird
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to combine the existing DSL to support more complex limiting scenarios, this PR is just the first step in providing workflow plugins to implement basic orchestration capabilities.
Fixes # (issue)
Checklist