feat: support Tencent Cloud Log Service by ychensha · Pull Request #7593 · apache/apisix

ychensha · 2022-08-02T08:42:40Z

Description

product doc

apisix log util is more powerfull than nginx access log, and it's useful for debugging and replaying later.

Fixes #7592

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls

soulbird · 2022-08-03T01:37:54Z

Thanks for your contribution. But please add a license to each file and add test cases first.

ychensha · 2022-08-03T02:45:57Z

any doc for testing? I have no exp for env setup & PERL testing framework...

soulbird · 2022-08-03T03:32:16Z

any doc for testing? I have no exp for env setup & PERL testing framework...

See: https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md

ychensha · 2022-08-03T11:50:36Z

any doc for testing? I have no exp for env setup & PERL testing framework...

See: https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md

tried.. I work on Mac, and now trapped in etcd configuration for more tesing case

add ut

fix lint fix lint

refa error & proto file load

tzssangglass · 2022-08-10T02:52:32Z

+    properties = {
+        cls_host = { type = "string" },
+        cls_topic = { type = "string" },
+        -- https://console.cloud.tencent.com/capi


what is this link for?

tzssangglass · 2022-08-10T03:13:54Z

I have a question: Is it that we can't do the test case to verify that this plugin is working correctly?
Because it requires a Tencent account and to make sure that this account is always available.

spacewander · 2022-08-10T06:15:52Z

I have a question: Is it that we can't do the test case to verify that this plugin is working correctly? Because it requires a Tencent account and to make sure that this account is always available.

We can inject a hook or mock into the code? Like:

apisix/t/plugin/zipkin2.t

Line 35 in b3d4b46

my $extra_init_by_lua = <<_EOC_;

apisix/t/plugin/opentelemetry.t

Line 553 in b3d4b46

--- extra_init_by_lua

ychensha · 2022-08-10T06:38:06Z

I have same question too. But same question can be applie to other plugins that have env matters

ychensha · 2022-08-10T06:49:27Z

I have same question too. But same question can be applie to other plugins that have env matters

ychensha · 2022-08-10T06:52:05Z

@spacewander @tzssangglass after code related conversations closed, I will do the function test again for the related code modification.

spacewander

Some comments need to be handled:
https://github.com/apache/apisix/pull/7593/files#r947501015
https://github.com/apache/apisix/pull/7593/files#r937476352
https://github.com/apache/apisix/pull/7593/files#r947500216

…logger

refa

tzssangglass · 2022-08-18T13:33:15Z

@ychensha pls don't use force-push to update code, or reviews' comments may be ignore.

spacewander · 2022-08-23T06:38:14Z

Let's merge master to make CI pass.

…logger

spacewander

Approve except https://github.com/apache/apisix/pull/7593/files#r941961486
As this PR is big enough, let's open another PR for the doc.

spacewander · 2022-08-24T02:56:36Z

As this PR is big enough, let's open another PR for the doc.

ychensha force-pushed the feature/cls-logger branch from 272f561 to 698adc5 Compare August 2, 2022 08:45

add tencent-cloud-cls

bd8c579

add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls add tencent-cloud-cls

ychensha force-pushed the feature/cls-logger branch from 698adc5 to bd8c579 Compare August 2, 2022 08:45

ychensha changed the title ~~[WIP]support Tencent Cloud Log Service~~ support Tencent Cloud Log Service Aug 2, 2022

soulbird changed the title ~~support Tencent Cloud Log Service~~ feat: support Tencent Cloud Log Service Aug 3, 2022

add tencent-cloud-cls

3b370ef

add ut

69e952b

add ut

ychensha force-pushed the feature/cls-logger branch 2 times, most recently from 78579de to 2ab9eef Compare August 4, 2022 01:23

fix lint

f57cc30

fix lint fix lint

ychensha force-pushed the feature/cls-logger branch from 2ab9eef to f57cc30 Compare August 4, 2022 01:23

ychensha added 2 commits August 4, 2022 09:54

add global tag

136e212

add tencent-cloud-cls

4e0e8ff

spacewander reviewed Aug 4, 2022

View reviewed changes

Comment thread apisix/plugins/tencent-cloud-cls/cls.proto Outdated

Comment thread apisix/plugins/tencent-cloud-cls/cls.proto Outdated

ychensha added 3 commits August 5, 2022 09:34

add custom log format

e969b5e

change random

b9ee01c

refa error & proto file load

fd30d49

refa error & proto file load

ychensha force-pushed the feature/cls-logger branch from 7b9e2d7 to fd30d49 Compare August 9, 2022 12:48

tzssangglass reviewed Aug 10, 2022

View reviewed changes

ychensha closed this Aug 10, 2022

spacewander reviewed Aug 18, 2022

View reviewed changes

Comment thread apisix/plugins/tencent-cloud-cls/cls-sdk.lua Outdated

Comment thread apisix/plugins/tencent-cloud-cls/cls-sdk.lua Outdated

add some comment

5d86522

ychensha force-pushed the feature/cls-logger branch from e3bff97 to 5d86522 Compare August 18, 2022 12:13

ychensha added 2 commits August 18, 2022 20:14

Merge branch 'master' of github.com:ychensha/apisix into feature/cls-…

e1066b2

…logger

refa

f4dd849

refa

ychensha force-pushed the feature/cls-logger branch from d83df93 to f4dd849 Compare August 18, 2022 12:53

ychensha added 2 commits August 19, 2022 11:31

fix ut style

4ed9d20

fix ut style

3c0ef7c

spacewander reviewed Aug 19, 2022

View reviewed changes

Comment thread t/plugin/tencent-cloud-cls.t

Comment thread t/plugin/tencent-cloud-cls.t Outdated

Comment thread t/plugin/tencent-cloud-cls.t Outdated

Comment thread t/plugin/tencent-cloud-cls.t Outdated

update ut

3c80122

tzssangglass requested changes Aug 22, 2022

View reviewed changes

Comment thread apisix/plugins/tencent-cloud-cls.lua Outdated

tzssangglass reviewed Aug 22, 2022

View reviewed changes

Comment thread apisix/plugins/tencent-cloud-cls.lua

remove secret key console link

e8ea496

spacewander reviewed Aug 22, 2022

View reviewed changes

Comment thread apisix/plugins/tencent-cloud-cls/cls-sdk.lua

Comment thread apisix/plugins/tencent-cloud-cls/cls-sdk.lua Outdated

Comment thread t/plugin/tencent-cloud-cls.t Outdated

Comment thread t/plugin/tencent-cloud-cls.t Outdated

Comment thread t/plugin/tencent-cloud-cls.t

ychensha added 4 commits August 23, 2022 10:15

refa ut

4dec98c

refa ut

93a98fb

refa

75b9314

refa

4309dc1

Merge branch 'master' of github.com:ychensha/apisix into feature/cls-…

3f5a1f0

…logger

spacewander previously approved these changes Aug 23, 2022

View reviewed changes

remove useless log

4461aaf

ychensha dismissed spacewander’s stale review via 4461aaf August 23, 2022 11:11

spacewander approved these changes Aug 24, 2022

View reviewed changes

spacewander requested a review from tzssangglass August 24, 2022 02:56

tzssangglass approved these changes Aug 24, 2022

View reviewed changes

spacewander merged commit 3c07574 into apache:master Aug 25, 2022

Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022

feat: support Tencent Cloud Log Service (apache#7593)

dfa29ce

Uh oh!

Conversation

ychensha commented Aug 2, 2022 • edited by spacewander Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

soulbird commented Aug 3, 2022

Uh oh!

ychensha commented Aug 3, 2022

Uh oh!

soulbird commented Aug 3, 2022

Uh oh!

ychensha commented Aug 3, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tzssangglass Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tzssangglass commented Aug 10, 2022

Uh oh!

spacewander commented Aug 10, 2022

Uh oh!

ychensha commented Aug 10, 2022

Uh oh!

ychensha commented Aug 10, 2022

Uh oh!

ychensha commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spacewander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tzssangglass commented Aug 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spacewander commented Aug 23, 2022

Uh oh!

spacewander left a comment

Choose a reason for hiding this comment

Uh oh!

spacewander commented Aug 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ychensha commented Aug 2, 2022 •

edited by spacewander

Loading

ychensha commented Aug 10, 2022 •

edited

Loading