feat(grafana json): update grafana json for nginx shared dict in prometheus#7529
Merged
Conversation
modify grafana json for nginx shared dict in prometheus
5 tasks
ccxhwmy
marked this pull request as ready for review
July 24, 2022 02:30
Contributor
spacewander
reviewed
Jul 27, 2022
spacewander
reviewed
Aug 1, 2022
| "steppedLine": false, | ||
| "targets": [ | ||
| { | ||
| "expr": "(apisix_shared_dict_free_space_bytes * 100) / on (name) apisix_shared_dict_capacity_bytes", |
Member
There was a problem hiding this comment.
If you are worried about showing instances will make the graph too complex, maybe we can add a comment that people can modify this query to show per-instance graph?
We can't add comment to a JSON file.
Contributor
Author
There was a problem hiding this comment.
If you are worried about showing instances will make the graph too complex, maybe we can add a comment that people can modify this query to show per-instance graph?
Does you mean add a comment like # we can modify the expr to show per-instance graph in json file?
soulbird
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

update grafana json for nginx shared dict in prometheus
Description
update grafana json to add nginx shared dict, which default config is
internal-status|upstream-healthcheck|worker-events|lrucache-lock|balancer-ewma|balancer-ewma-locks|balancer-ewma-last-touched-at|etcd-cluster-health-check.Fixes # (issue)
Checklist