Skip to content

fix: cleanup variable before re list and watch#7506

Merged
spacewander merged 2 commits into
apache:masterfrom
zhixiongdu027:master
Jul 22, 2022
Merged

fix: cleanup variable before re list and watch#7506
spacewander merged 2 commits into
apache:masterfrom
zhixiongdu027:master

Conversation

@zhixiongdu027

@zhixiongdu027 zhixiongdu027 commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Description

Fixs #7489

Checklist

  • [] I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@zhixiongdu027

Copy link
Copy Markdown
Contributor Author

Hi, @tokers @crazyMonkey1995

Please help review, Many tks.

Comment thread apisix/discovery/kubernetes/informer_factory.lua
@tokers

tokers commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

I just re-ran the failed CI jobs.

@tzssangglass

Copy link
Copy Markdown
Member

pls rebase the upstream master branch to your PR branch, the CI failed has been fixed in the master branch of upstream.

@zhixiongdu027

Copy link
Copy Markdown
Contributor Author

@tzssangglass @tokers
Please help re start ci .

@spacewander

Copy link
Copy Markdown
Member

@tzssangglass @tokers Please help re start ci .

Done

@spacewander
spacewander merged commit 3b1cda7 into apache:master Jul 22, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Aug 17, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants