Skip to content

fix(upstream): http connection was put into https connection pool#7466

Merged
spacewander merged 1 commit into
apache:masterfrom
spacewander:lka
Jul 15, 2022
Merged

fix(upstream): http connection was put into https connection pool#7466
spacewander merged 1 commit into
apache:masterfrom
spacewander:lka

Conversation

@spacewander

Copy link
Copy Markdown
Member

This bug is introduced in 3dddf41
Signed-off-by: spacewander [email protected]

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander
spacewander marked this pull request as ready for review July 14, 2022 09:09
@spacewander
spacewander merged commit 7b6b30f into apache:master Jul 15, 2022
spacewander added a commit to spacewander/incubator-apisix that referenced this pull request Aug 12, 2022
@atealxt

atealxt commented Aug 16, 2022

Copy link
Copy Markdown

This patch should hotfix to 2.13 LTS and 2.14 too.

It was such a headache which spent us a couple of hours to recover. I paste some notes/docs here just in case someone is searching similar scene:

Error behavior:
Http request accidental get unexpected response such as 404, wrong content from another route/upstream.

Steps to Reproduce:

  1. setup two HTTP routes A a.example.com, B b.example.com
  2. upload ssl certificate which SNI like *.example.com
  3. setup one HTTPS route C c.example.com
  4. request C followed by A and B will get disordered response.

spacewander added a commit that referenced this pull request Aug 17, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@wangfeng22

Copy link
Copy Markdown

why did this happen? some routes work well, but some return 404 pages not found. @spacewander

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants