Skip to content

change(grpc): add the correspondence between grpc code and http code#7419

Merged
spacewander merged 2 commits into
apache:masterfrom
juststillthinking:add-the-correspondence-between-grpc-code-and-http-code
Jul 13, 2022
Merged

change(grpc): add the correspondence between grpc code and http code#7419
spacewander merged 2 commits into
apache:masterfrom
juststillthinking:add-the-correspondence-between-grpc-code-and-http-code

Conversation

@juststillthinking

Copy link
Copy Markdown
Contributor

Description

Base on google doc: https://cloud.google.com/apis/design/errors#handling_errors

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

tokers
tokers previously approved these changes Jul 10, 2022
spacewander
spacewander previously approved these changes Jul 10, 2022
["12"] = 501,
["13"] = 500,
["14"] = 503,
["1"] = 499, -- CANCELLED

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the source link as a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@juststillthinking
juststillthinking dismissed stale reviews from spacewander and tokers via 09afe53 July 11, 2022 10:46
@spacewander
spacewander merged commit b498e98 into apache:master Jul 13, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants