Skip to content

feat: response body format#7366

Merged
spacewander merged 3 commits into
apache:nextfrom
tzssangglass:rbf
Jul 5, 2022
Merged

feat: response body format#7366
spacewander merged 3 commits into
apache:nextfrom
tzssangglass:rbf

Conversation

@tzssangglass

@tzssangglass tzssangglass commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  1. remove action field in response body, it is useless
  2. make the response body format simpler for list of object

Fixes #7320

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass
tzssangglass marked this pull request as ready for review July 1, 2022 06:30
membphis
membphis approved these changes Jul 1, 2022
View reviewed changes

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spacewander
spacewander reviewed Jul 3, 2022
View reviewed changes
Comment thread apisix/core/etcd.lua Outdated
Comment thread t/admin/response_body_format.t Outdated
soulbird
soulbird reviewed Jul 4, 2022
View reviewed changes
Comment thread apisix/core/etcd.lua
@tzssangglass
tzssangglass requested a review from spacewander July 4, 2022 08:17
@tzssangglass tzssangglass mentioned this pull request Jul 4, 2022
Merged
5 tasks
@spacewander
spacewander merged commit 83ee13b into apache:next Jul 5, 2022
spacewander pushed a commit that referenced this pull request Aug 3, 2022
@tzssangglass
feat: V3 features from the next branch (#7585)
6accc81 
* ci: add next branche to CI coverage (#7359)

* feat: adjust some list uris of V3 API (#7364)

* feat: response body format (#7366)

* feat: support paging to get a list of objects  (#7379)

* feat: filter fields supported by all objects (#7391)

* resolve code review
@tzssangglass tzssangglass mentioned this pull request Aug 9, 2022
Merged
5 tasks
@tzssangglass
tzssangglass deleted the rbf branch October 10, 2022 10:42
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@tzssangglass @Liu-Junlin
feat: V3 features from the next branch (apache#7585)
0b184ef 
* ci: add next branche to CI coverage (apache#7359)

* feat: adjust some list uris of V3 API (apache#7364)

* feat: response body format (apache#7366)

* feat: support paging to get a list of objects  (apache#7379)

* feat: filter fields supported by all objects (apache#7391)

* resolve code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes
@membphis membphis membphis approved these changes
@soulbird soulbird soulbird approved these changes
@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tzssangglass @spacewander @membphis @soulbird