Can we add some test cases to cover the changes?

Can we add some test cases to cover the changes?

I don't know how this test case can be written to cover this scenario.

Shall we query the data received by skywaling?

Can we add some test cases to cover the changes?

I don't know how this test case can be written to cover this scenario.

Shall we query the data received by skywaling?

Just for reference: https://github.com/apache/apisix/blob/master/t/plugin/skywalking-logger.t#L124-L196.
However, in the instance of executing the github action, the hostname may not be determined

we can verify hostname like:

we can verify hostname like:

apisix/t/plugin/server-info.t

Line 108 in afce02c

qr/^{"boot_time":\d+,"etcd_version":"[\d\.]+","hostname":"[a-zA-Z\-0-9\.]+","id":[a-zA-Z\-0-9]+,"version":"[\d\.]+"}$/

This won't work, because $hostname can also be matched but we expect the value to be something other than $hostname

how about ^[a-zA-Z\-0-9\.]+

how about ^[a-zA-Z\-0-9\.]+

service_instance_name is user-defined and can be set to any value such as #xxx.
This is just for testing, it should work.

But I think my current use case should be ok, we just need to judge that service_instance_name is not equal to the string $hostname and not equal to the empty string.

--- no_error_log eval
qr/\\\"serviceInstance\\\":\\\"\$hostname\\\"/
qr/\\\"serviceInstance\\\":\\\"\\\"/

I reruned the failed CI and if CI passed, we can merge it.

please rerun ci