fix: grpc-transcode request support object array #7231
Merged
Merged
Conversation
Jon-Gaara
changed the title
spacewander
reviewed
Jun 12, 2022
spacewander
left a comment
spacewander
left a comment
Member
There was a problem hiding this comment.
Please make the CI pass, thanks!
| if request_table[name] == nil then | ||
| sub = default_values and default_values[name] | ||
| elseif core.table.isarray(request_table[name]) then | ||
| local sub_array = core.table.new(#request_table[name],0) |
Member
There was a problem hiding this comment.
Suggested change
| local sub_array = core.table.new(#request_table[name],0) | |
| local sub_array = core.table.new(#request_table[name], 0) |
| sub = default_values and default_values[name] | ||
| elseif core.table.isarray(request_table[name]) then | ||
| local sub_array = core.table.new(#request_table[name],0) | ||
| for i,value in ipairs(request_table[name]) do |
Member
There was a problem hiding this comment.
Suggested change
| for i,value in ipairs(request_table[name]) do | |
| for i, value in ipairs(request_table[name]) do |
Contributor
Author
There was a problem hiding this comment.
I have modified and submitted，but the CI not pass
Member
|
Let's make the lint pass with reindex: https://github.com/apache/apisix/runs/6855357196?check_suite_focus=true |
spacewander
approved these changes
Jun 14, 2022
soulbird
approved these changes
Jun 17, 2022
tzssangglass
approved these changes
Jun 17, 2022
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jun 20, 2022
Signed-off-by: spacewander <[email protected]>
spacewander
pushed a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jun 20, 2022
Co-authored-by: jon.yu <[email protected]>
spacewander
pushed a commit
that referenced
this pull request
Jun 20, 2022
Co-authored-by: jon.yu <[email protected]>
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Co-authored-by: jon.yu <[email protected]>
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Co-authored-by: jon.yu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
grpc-trancode if request have object array,upstream accept is empty
Fixes #5591
Checklist