docs: add re case on response-rewrite plugin#7197
Merged
Merged
Conversation
qizhendong1
force-pushed
the
debug-conf-check
branch
from
June 6, 2022 07:46
795a2f8 to
8d82872
Compare
qizhendong1
marked this pull request as ready for review
June 6, 2022 07:47
soulbird
reviewed
Jun 6, 2022
qizhendong1
force-pushed
the
debug-conf-check
branch
from
June 6, 2022 14:21
8d82872 to
05fae30
Compare
soulbird
previously approved these changes
Jun 7, 2022
juzhiyuan
reviewed
Jun 7, 2022
qizhendong1
force-pushed
the
debug-conf-check
branch
from
June 7, 2022 02:49
05fae30 to
a729489
Compare
juzhiyuan
reviewed
Jun 7, 2022
| {"code":"ok","message":"new json body"} | ||
| ``` | ||
|
|
||
| Replace the string X-Amzn-Trace-Id of body to X-Amzn-Trace-Id-Replace. |
Member
There was a problem hiding this comment.
Hi, the changes you added are more like a scenario section (not related to the Enabling section), please see https://github.com/apache/apisix/blob/a729489152a032571b9bcd9b19edc75949755fbe/docs/en/latest/plugins/response-rewrite.md
cc @navendu-pottekkat should we accept this? If yes, then what titles should we use?
Member
There was a problem hiding this comment.
This could be added as an example. But it is not clear to me that we are replacing the header using regex.
Contributor
Author
There was a problem hiding this comment.
I add description let it clear.
qizhendong1
force-pushed
the
debug-conf-check
branch
2 times, most recently
from
June 7, 2022 07:11
bd52bd5 to
d372482
Compare
pottekkat
reviewed
Jun 7, 2022
qizhendong1
force-pushed
the
debug-conf-check
branch
from
June 8, 2022 01:05
d372482 to
934777f
Compare
qizhendong1
force-pushed
the
debug-conf-check
branch
from
June 8, 2022 08:02
934777f to
e7bd72b
Compare
pottekkat
approved these changes
Jun 9, 2022
juzhiyuan
approved these changes
Jun 9, 2022
juzhiyuan
left a comment
juzhiyuan
left a comment
Member
There was a problem hiding this comment.
We could think about adding a separate section like Examples in the future 😉
tao12345666333
approved these changes
Jun 9, 2022
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
Jun 16, 2022
* upstream/master: (46 commits) docs: fix err in batch-processor (apache#7259) docs(deployment): sync design to online docs (apache#7256) feat(deployment): add structure of traditional role (apache#7249) fix(benchmark): write worker_processes into config.yaml (apache#7250) docs: correct the repo url (apache#7253) feat: Add support for capturing OIDC refresh tokens (apache#7220) feat(ssl): support get upstream cert from ssl object (apache#7221) chore: validate etcd conf strictly (apache#7245) fix(api-response): check response header format (apache#7238) fix: duplicate X-Forwarded-Proto will be sent as string (apache#7229) fix: distinguish different upstreams even they have the same addr (apache#7213) docs: make company on README more preciser (apache#7230) test: remove unused required etcd (apache#7225) fix: add debug yaml validation (apache#7201) change: remove upstream.enable_websocket which is deprecated since 2020 (apache#7222) docs: add re case on response-rewrite plugin (apache#7197) docs: add API Gateway keyword and AWS graviton3. (apache#7217) fix(response-rewrite): schema format error (apache#7212) docs(proxy-rewrite): remove empty space (apache#7210) chore: require http_stub_status_module exists (apache#7208) ...
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue) #7130
Checklist