fix(grpc-transcode): pb_option should be set on the route#7116
Merged
Conversation
spacewander
changed the title
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
May 24, 2022 11:30
spacewander
requested review from
bisakhmondal,
bzp2010,
leslie-tsang and
tzssangglass
May 24, 2022 11:34
bisakhmondal
left a comment
bisakhmondal
left a comment
Member
There was a problem hiding this comment.
In general look good to me. Thanks!
Comment on lines
+64
to
+70
| table.sort(options) | ||
| for i, v in ipairs(options) do | ||
| if cur_opts[i] ~= v then | ||
| same = false | ||
| break | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
I assume the extra check of pointer and values are for perf improvements. But just a small heads up, this check will fail on the second time the set_option method is called and on the first call, the cur_opts was nil.
In that scenario, at the first run, the unsorted table will be cached - L81.
L66 will try to match with the sorted table options.
Anyway, just a small nitpicking indeed : )
tokers
previously approved these changes
May 25, 2022
tzssangglass
previously approved these changes
May 25, 2022
Signed-off-by: spacewander <[email protected]>
leslie-tsang
approved these changes
May 25, 2022
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
May 25, 2022
* upstream/master: test: make sure the nginx.pid is written (apache#7122) fix(grpc-transcode): pb_option should be set on the route (apache#7116) feat(ops): check dns resolver address is valid (apache#7079) fix: reduce memory usage when abnormal weights are given in chash (apache#7103)
spacewander
added a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: spacewander <[email protected]>
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Signed-off-by: spacewander <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
Description
Fixes #7025
Checklist