feat(ops): check process running with posix.signal insteadof lsof by kwanhur · Pull Request #7006 · apache/apisix

kwanhur · 2022-05-08T12:51:02Z

Description

Partial OS no lsof tool, so if use lsof to check APISIX running or not will fail.

Now send signal none(0) to check via luaposix.

remove shell command lsof dependency
use signal SIGNONE(0) check process running or not

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

* remove shell command lsof dependency resolve apache#6977 * use signal SIGNONE(0) check process running or not Signed-off-by: kwanhur <[email protected]>

Signed-off-by: kwanhur <[email protected]>

This reverts commit 21b9bc3. Signed-off-by: kwanhur <[email protected]>

Signed-off-by: kwanhur <[email protected]>

This reverts commit c8ee3bb. Signed-off-by: kwanhur <[email protected]>

Signed-off-by: kwanhur <[email protected]>

kwanhur · 2022-05-14T02:27:00Z

Any test case need to cover no such process? It seems no similar in test_cli_main.sh.

Signed-off-by: kwanhur <[email protected]>

spacewander · 2022-05-15T11:35:59Z

Please make the CI pass, thanks!

Signed-off-by: kwanhur <[email protected]>

kwanhur · 2022-05-15T15:20:06Z

CI action run failed on t/plugin/traffic-split.t 6441580676 and t/plugin/api-breaker.t 6441580676 6441580789

Plz trigger to rerun them :-)

spacewander · 2022-05-16T06:54:28Z

Let's merge master to make CI pass.

kwanhur · 2022-05-16T10:04:59Z

Had merged. Plz rerun this action.

cc @spacewander @tokers @tzssangglass

tokers · 2022-05-17T01:18:31Z

@kwanhur Please make the CI pass, thanks!

tzssangglass · 2022-05-17T03:06:36Z

Had merged. Plz rerun this action.

done

Signed-off-by: kwanhur <[email protected]>

spacewander · 2022-05-19T01:57:49Z

 echo "pass: ignore stale nginx.pid"

+# check operation not permitted
+sudo make run


Can we replace this test with a test that checks no such process? It seems we don't have test to cover it.

Signed-off-by: kwanhur <[email protected]>

kwanhur · 2022-05-19T13:44:01Z

These failed workflows take error on compilation, plz trigger to re-run them, thanks very much. @tzssangglass

../ngx_lua-0.10.20/src/ngx_http_lua_common.h:26:10: fatal error: ngx_meta_lua_api.h: No such file or directory
 #include "ngx_meta_lua_api.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

…ache#7006) Signed-off-by: kwanhur <[email protected]> Co-authored-by: 罗泽轩 <[email protected]>

* upsgrteam/master: (351 commits) fix(proxy-cache): bypass when method mismatch cache_method (apache#7111) chore(script): support to install dependencies under arm64 (apache#7091) chore(ci): use the latest build script for apisix-base (apache#7090) fix(batch-requests): ignore "unix:" in the configuration (apache#7106) fix: install dependencies issues (apache#7092) feat(ops): use lua libs to backup config file insteadof shell command (apache#7048) test: reduce CI failure caused by flaky tests (apache#7085) chore(ci): move set_dns.sh to ci dir (apache#7089) feat: release 2.14.0 (apache#7057) docs: update "Tracers" Plugins (apache#7086) docs: update "Traffic" Plugin docs 3 (apache#7064) docs: update "Serverless" Plugins (apache#7076) feat(ops): check process running with posix.signal insteadof lsof (apache#7006) docs: modify how-to-build filename (apache#7087) docs: fix link of hot-reload in docs (apache#7081) chore(ci): apt update before install (apache#7080) docs: add pubsub develop example for kafka (apache#7059) ci: enable rebase in some situation (apache#7074) fix: redirect http to https but port not change (apache#7065) ci: make it pass under OpenResty 1.21 (apache#7067) ...

) Signed-off-by: kwanhur <[email protected]> Co-authored-by: 罗泽轩 <[email protected]>

kwanhur dismissed a stale review via e897939 May 8, 2022 13:04

kwanhur force-pushed the cli-check-pid branch from 68908cf to e897939 Compare May 8, 2022 13:04

feat(ops): check process running with posix.signal insteadof lsof

9bab5b9

* remove shell command lsof dependency resolve apache#6977 * use signal SIGNONE(0) check process running or not Signed-off-by: kwanhur <[email protected]>

kwanhur force-pushed the cli-check-pid branch from e897939 to 9bab5b9 Compare May 8, 2022 13:11

kwanhur marked this pull request as ready for review May 8, 2022 14:20

tokers reviewed May 9, 2022

View reviewed changes

Comment thread apisix/cli/ops.lua

test(ops): cases check apisix running

21b9bc3

Signed-off-by: kwanhur <[email protected]>

tzssangglass reviewed May 9, 2022

View reviewed changes

Comment thread apisix/cli/ops.lua Outdated

tzssangglass reviewed May 9, 2022

View reviewed changes

Comment thread apisix/cli/ops.lua Outdated

tokers previously approved these changes May 10, 2022

View reviewed changes

spacewander reviewed May 10, 2022

View reviewed changes

Comment thread apisix/cli/ops.lua Outdated

Comment thread t/cli/test_ops.sh Outdated

kwanhur added 2 commits May 10, 2022 19:35

Revert "test(ops): cases check apisix running"

1de9ef3

This reverts commit 21b9bc3. Signed-off-by: kwanhur <[email protected]>

feat(ops): use posix.errno constant ESRCH

e4ecd65

Signed-off-by: kwanhur <[email protected]>

kwanhur dismissed tokers’s stale review via e4ecd65 May 10, 2022 11:41

spacewander reviewed May 12, 2022

View reviewed changes

Comment thread apisix/cli/ops.lua

Comment thread apisix/cli/ops.lua Outdated

Comment thread apisix/cli/ops.lua

kwanhur added 4 commits May 12, 2022 20:01

feat(ops): remove redundant blank line

f9298e1

Signed-off-by: kwanhur <[email protected]>

test(ops): update fake pid 66666 to check running or not

c8ee3bb

Signed-off-by: kwanhur <[email protected]>

Revert "test(ops): update fake pid 66666 to check running or not"

41364ed

This reverts commit c8ee3bb. Signed-off-by: kwanhur <[email protected]>

feat(ops): return invalid when pid negative

b58dbf9

Signed-off-by: kwanhur <[email protected]>

tzssangglass previously approved these changes May 14, 2022

View reviewed changes

feat(ops): return invalid when pid zero

055f5bc

Signed-off-by: kwanhur <[email protected]>

kwanhur dismissed tzssangglass’s stale review via 055f5bc May 15, 2022 09:59

kwanhur added 2 commits May 15, 2022 22:23

test(ops): check running when run repeatedly

3e8c4d5

Signed-off-by: kwanhur <[email protected]>

test(ops): remove unused test file

d1801ca

Signed-off-by: kwanhur <[email protected]>

Merge branch 'master' of github.com:apache/apisix into cli-check-pid

4cc471c

spacewander reviewed May 17, 2022

View reviewed changes

Comment thread t/cli/test_main.sh

test(ops): case operation not permitted

bd64795

Signed-off-by: kwanhur <[email protected]>

spacewander reviewed May 19, 2022

View reviewed changes

test(ops): case no corresponding process

772d395

Signed-off-by: kwanhur <[email protected]>

spacewander previously approved these changes May 20, 2022

View reviewed changes

Comment thread t/cli/test_main.sh Outdated

Update t/cli/test_main.sh

a108ac9

spacewander dismissed their stale review via a108ac9 May 20, 2022 04:56

spacewander approved these changes May 20, 2022

View reviewed changes

tzssangglass approved these changes May 20, 2022

View reviewed changes

spacewander merged commit 1a6f1b8 into apache:master May 20, 2022

Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022

feat(ops): check process running with posix.signal insteadof lsof (ap…

5252f32

…ache#7006) Signed-off-by: kwanhur <[email protected]> Co-authored-by: 罗泽轩 <[email protected]>

spacewander added a commit that referenced this pull request Jun 30, 2022

feat(ops): check process running with posix.signal insteadof lsof (#7006

eea2b7f

) Signed-off-by: kwanhur <[email protected]> Co-authored-by: 罗泽轩 <[email protected]>

Uh oh!

Conversation

kwanhur commented May 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kwanhur commented May 14, 2022

Uh oh!

spacewander commented May 15, 2022

Uh oh!

kwanhur commented May 15, 2022

Uh oh!

spacewander commented May 16, 2022

Uh oh!

kwanhur commented May 16, 2022

Uh oh!

tokers commented May 17, 2022

Uh oh!

tzssangglass commented May 17, 2022

Uh oh!

Uh oh!

spacewander May 19, 2022

Choose a reason for hiding this comment

Uh oh!

kwanhur May 19, 2022

Choose a reason for hiding this comment

Uh oh!

kwanhur commented May 19, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kwanhur commented May 8, 2022 •

edited

Loading