Skip to content

feat(xRPC): support log filter#6960

Merged
spacewander merged 14 commits into
apache:masterfrom
tzssangglass:logfilter
May 12, 2022
Merged

feat(xRPC): support log filter#6960
spacewander merged 14 commits into
apache:masterfrom
tzssangglass:logfilter

Conversation

@tzssangglass

@tzssangglass tzssangglass commented Apr 28, 2022

Copy link
Copy Markdown
Member

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass
tzssangglass marked this pull request as ready for review April 28, 2022 09:30
@tzssangglass
tzssangglass marked this pull request as draft April 28, 2022 09:30
@tzssangglass
tzssangglass marked this pull request as ready for review May 6, 2022 07:05
spacewander
spacewander reviewed May 6, 2022
View reviewed changes
Comment thread apisix/schema_def.lua
Comment thread apisix/stream/xrpc/runner.lua
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread apisix/stream/xrpc/runner.lua Outdated
spacewander
spacewander reviewed May 8, 2022
View reviewed changes
Comment thread apisix/schema_def.lua Outdated
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread apisix/stream/xrpc/runner.lua Outdated
spacewander
spacewander reviewed May 8, 2022
View reviewed changes
Comment thread t/xrpc/pingpong2.t Outdated
spacewander
spacewander reviewed May 9, 2022
View reviewed changes
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread t/xrpc/apisix/stream/xrpc/protocols/pingpong/init.lua Outdated
@tzssangglass
tzssangglass requested a review from spacewander May 9, 2022 13:09
spacewander
spacewander reviewed May 10, 2022
View reviewed changes
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread apisix/stream/xrpc/sdk.lua Outdated
spacewander
spacewander reviewed May 10, 2022
View reviewed changes
Comment thread apisix/stream/xrpc/runner.lua Outdated
@tzssangglass
tzssangglass requested a review from spacewander May 11, 2022 01:30
spacewander
spacewander reviewed May 11, 2022
View reviewed changes
Comment thread apisix/stream/xrpc/runner.lua Outdated
Comment thread apisix/stream/xrpc/runner.lua
Comment thread apisix/stream/xrpc/runner.lua
Comment thread apisix/stream/xrpc/runner.lua Outdated
@tzssangglass
tzssangglass requested a review from spacewander May 11, 2022 09:08
spacewander
spacewander previously approved these changes May 11, 2022
View reviewed changes
Comment thread apisix/stream/xrpc/runner.lua Outdated
@juzhiyuan
juzhiyuan requested a review from leslie-tsang May 11, 2022 14:26
@spacewander
spacewander merged commit 935e62f into apache:master May 12, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@tzssangglass @Liu-Junlin
feat(xRPC): support log filter (apache#6960)
81903a2
@tzssangglass
tzssangglass deleted the logfilter branch May 24, 2022 06:25
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@tzssangglass @spacewander
feat(xRPC): support log filter (#6960)
e1e8d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes
@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tzssangglass @spacewander @leslie-tsang