feat(request-id): add algorithm support nanoid#6779
Merged
Conversation
aikin-vip
changed the title
aikin-vip
changed the title
tokers
reviewed
Apr 2, 2022
spacewander
reviewed
Apr 2, 2022
spacewander
left a comment
spacewander
left a comment
Member
There was a problem hiding this comment.
The installation in https://github.com/CriztianiX/lua-resty-nanoid is incorrect. We should fix it like:
https://github.com/stuartcarnie/lua-snowflake/blob/master/rockspec/snowflake-1.0-1.rockspec
Contributor
Author
Contributor
Author
|
I think I've solved all the problems, please review. @spacewander @tokers |
spacewander
approved these changes
Apr 7, 2022
shuaijinchao
approved these changes
Apr 7, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Contributor
|
Hi @aikin-vip , could you please have a look at the issue #8931, and hopefully resolve it. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nanoid is faster than UUID
related repos:
Checklist