fix(DNS): support SRV with port 0#6739
Merged
Merged
Conversation
rfc2782 allows the port range in [0, 65535] but doesn't mention what should be done when the port is 0. Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
March 29, 2022 04:50
tzssangglass
approved these changes
Mar 29, 2022
shuaijinchao
approved these changes
Mar 31, 2022
tokers
approved these changes
Mar 31, 2022
leslie-tsang
approved these changes
Mar 31, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
May 27, 2022
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
May 29, 2022
spacewander
added a commit
that referenced
this pull request
May 29, 2022
spacewander
added a commit
that referenced
this pull request
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rfc2782 allows the port range in [0, 65535] but doesn't mention what
should be done when the port is 0.
Signed-off-by: spacewander [email protected]
Description
Fixes #6732
Checklist