feat(wasm): support getting request body#6325
Merged
Merged
Conversation
spacewander
force-pushed
the
wab
branch
2 times, most recently
from
February 15, 2022 09:05
9b84730 to
0333f8f
Compare
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
February 15, 2022 11:53
tzssangglass
previously approved these changes
Feb 16, 2022
bzp2010
previously approved these changes
Feb 16, 2022
|
|
||
| my $a6_ngx_vars = ""; | ||
| if ($version =~ m/\/apisix-nginx-module/) { | ||
| $a6_ngx_vars = <<_EOC_; |
Member
There was a problem hiding this comment.
Suggested change
| $a6_ngx_vars = <<_EOC_; | |
| $a6_ngx_vars .= <<_EOC_; |
Would this be better ? If there is a new setting that needs to be applied, we don't need to change it.
Member
Author
There was a problem hiding this comment.
There is no need to append the str to $a6_ngx_vars which is empty if apisix-nginx-module is missing.
| hello | ||
| --- grep_error_log eval | ||
| qr/request get body: \w+/ | ||
| --- grep_error_log_out |
Member
There was a problem hiding this comment.
--- grep_error_log_outIs it possible to remove this ?
Member
Author
There was a problem hiding this comment.
No. A empty grep_error_log_out means "should not grep any result with the pattern given in grep_error_log".
starsz
reviewed
Feb 16, 2022
Co-authored-by: leslie <[email protected]>
spacewander
dismissed stale reviews from bzp2010 and tzssangglass
via
February 16, 2022 13:45
82d88b0
leslie-tsang
approved these changes
Feb 16, 2022
tzssangglass
approved these changes
Feb 17, 2022
bzp2010
self-requested a review
February 17, 2022 01:33
bzp2010
approved these changes
Feb 17, 2022
starsz
approved these changes
Feb 17, 2022
shuaijinchao
approved these changes
Feb 17, 2022
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
Feb 23, 2022
* upstream: (52 commits) feat: add kubernetes discovery module (apache#4880) docs: fix For L7 proxy -> For L4 proxy (apache#6423) fix(deps): upgrade jsonschema to 0.9.8 (apache#6407) docs: translate Chinese to English in en clickhouse-logger (apache#6416) docs: add zh proxy-control.md&modify other doc error (apache#6346) docs: update public API relative usage (apache#6318) docs(cn): remove datadog from sidebar & fix doc lint conf (apache#6411) fix(request-validation): should not limit the urlencoded post args number (apache#6396) docs: fix configuration file typo (apache#6395) docs(extern-plugin): the implementation of runner (apache#6336) docs: polishing skywalking-logger plugin's docs (apache#6377) doc: adjust the directory structure of observability's documents (apache#6391) change(admin): empty nodes should be encoded as array (apache#6384) fix: should not limit the header number (apache#6379) ci: remove unnecessary tmate action (apache#6367) fix(opentelemetry): batch_span_processor export zero length spans (apache#6349) feat(graphql): support http get and post json request (apache#6343) feat: support for configuring the number of etcd health check retries (apache#6322) feat(wasm): support getting request body (apache#6325) fix(hmac-auth): hmac-auth plugin sort array param (apache#6314) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: