fix(proto): avoid sharing state#6199
Merged
Merged
Conversation
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
January 25, 2022 10:32
bisakhmondal
approved these changes
Jan 25, 2022
Comment on lines
+33
to
+34
| -- clear pb state | ||
| pb.state(nil) |
Member
There was a problem hiding this comment.
Isn't it redundant? I think Line 54 is already retrieving the current pb state and setting it to nil.
Member
Author
There was a problem hiding this comment.
There is a default pb state that we need to clear.
tzssangglass
approved these changes
Jan 26, 2022
leslie-tsang
approved these changes
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: