You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a lot of content in this PR revision, so I am providing a modifications list here.
Modified content
Core modifications: apisix/admin/plugin_metadata.lua, apisix/api_router.lua, apisix/init.lua
Remove the public API match in the access phase and remove the plugin interceptor.
Plugin modification: apisix/plugins/public-api.lua
Remove the skip global rule, it will now be executed unconditionally (since the public API is now also managed by the normal HTTP request router)
Tests based on Test::Nginx: Several files in *.t
Add a pre-step for creating public API routes (those provide public API).
Modify the default settings for partial GET /t and no_error_log.
CLI tests: t/cli/test_admin.sh, t/cli/test_prometheus.sh
Add a pre-step for creating public API routes (node-status and prometheus plugin)
Chaos tests
Add a pre-step for creating public API routes (prometheus plugin)
Other
This PR does not contain documentation for the public API and changes to its documentation involving plugin interceptors and plugin development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spacewander
changed the title
What this PR does / why we need it:
Tweak the
public-apiplugin to no longer expose the public API by default, while removing the skip global rules feature and configuration.Pre-submission checklist: