feat: add opentelemetry plugin#6119
Merged
Merged
Conversation
leslie-tsang
requested changes
Jan 16, 2022
leslie-tsang
left a comment
leslie-tsang
left a comment
Member
There was a problem hiding this comment.
Hello there, Thanks for you contribution, Can you send a email to the mail list ?
yangxikun
changed the title
spacewander
reviewed
Jan 17, 2022
spacewander
reviewed
Jan 17, 2022
|
great, brother. |
spacewander
reviewed
Jan 18, 2022
spacewander
reviewed
Jan 18, 2022
spacewander
reviewed
Jan 19, 2022
spacewander
reviewed
Jan 21, 2022
membphis
reviewed
Jan 21, 2022
spacewander
approved these changes
Jan 23, 2022
spacewander
changed the title
spacewander
requested review from
bisakhmondal,
bzp2010,
membphis,
shuaijinchao and
tzssangglass
January 24, 2022 07:53
bisakhmondal
approved these changes
Jan 24, 2022
bisakhmondal
left a comment
bisakhmondal
left a comment
Member
There was a problem hiding this comment.
Great job here. Kudos to you!
Member
|
@yangxikun is it possible to make an |
Member
|
Comment on lines
+25
to
+26
| local trace_id_ratio_sampler_new = | ||
| require("opentelemetry.trace.sampling.trace_id_ratio_sampler").new |
Member
There was a problem hiding this comment.
Suggested change
| local trace_id_ratio_sampler_new = | |
| require("opentelemetry.trace.sampling.trace_id_ratio_sampler").new | |
| local trace_id_ratio_sampler_new = require("opentelemetry.trace.sampling.trace_id_ratio_sampler").new |
I personally prefer to put them on the same line.
Member
There was a problem hiding this comment.
I guess it's for Linting? > 100 char
Contributor
Author
There was a problem hiding this comment.
Yes, for linting.
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add opentelemetry plugin.
Fix #3891
Pre-submission checklist: