change: enable HTTP when stream proxy is set and enable_admin is true#5867
Merged
Conversation
For development, this change let us don't need to specify `only: false` additionally. For DP which is used as L4 proxy, this change won't bring any difference. Also, it makes the documentation of stream plugin simpler. Signed-off-by: spacewander <[email protected]>
spacewander
changed the title
spacewander
marked this pull request as ready for review
December 21, 2021 02:44
leslie-tsang
requested changes
Dec 21, 2021
Co-authored-by: leslie <[email protected]>
shuaijinchao
approved these changes
Dec 23, 2021
tzssangglass
approved these changes
Dec 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For development, this change let us don't need to specify
only: falseadditionally.For DP which is used as L4 proxy, this change won't bring any
difference.
Also it makes the documentation of stream plugin simpler.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: