fix(ext-plugin): don't use stale key#5782
Merged
Merged
Conversation
spacewander
reviewed
Dec 13, 2021
|
|
||
| lrucache = core.lrucache.new({ | ||
| type = "plugin", | ||
| invalid_stale = true, |
Member
There was a problem hiding this comment.
Could you do some refactor so we don't need to specify the lrucache options twice? Thanks!
spacewander
approved these changes
Dec 13, 2021
spacewander
left a comment
spacewander
left a comment
Member
There was a problem hiding this comment.
Maybe we can rename create_lrucache to recreate_lrucache?
Contributor
Author
okey, done |
tzssangglass
approved these changes
Dec 14, 2021
bzp2010
pushed a commit
to bzp2010/apisix
that referenced
this pull request
Dec 30, 2021
Co-authored-by: sunaowei <sunaowei@neild>
bzp2010
pushed a commit
to bzp2010/apisix
that referenced
this pull request
Dec 31, 2021
Co-authored-by: sunaowei <sunaowei@neild>
bzp2010
pushed a commit
to bzp2010/apisix
that referenced
this pull request
Dec 31, 2021
Co-authored-by: sunaowei <sunaowei@neild>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ext_plugin an expired key in lrucachd that could not find in go runner。
patch for #5309
Pre-submission checklist: