feat(plugin): support google cloud logging service#5538
Merged
spacewander merged 14 commits intoNov 23, 2021
Conversation
shuaijinchao
marked this pull request as ready for review
November 19, 2021 08:46
tokers
reviewed
Nov 19, 2021
tokers
left a comment
tokers
left a comment
Contributor
There was a problem hiding this comment.
Simple review round with some questions.
shuaijinchao
force-pushed
the
feature/plugin/google/logging
branch
from
November 19, 2021 09:07
93a8292 to
7473e9d
Compare
…ao/apisix into feature/plugin/google/logging2 � Conflicts: � conf/config-default.yaml
spacewander
reviewed
Nov 21, 2021
spacewander
reviewed
Nov 21, 2021
juzhiyuan
reviewed
Nov 22, 2021
spacewander
reviewed
Nov 23, 2021
spacewander
approved these changes
Nov 23, 2021
tzssangglass
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FIX #5474
Pre-submission checklist: