feat: initial wasm support#5288
Merged
Merged
Conversation
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
October 20, 2021 08:14
tokers
reviewed
Oct 20, 2021
|
|
||
| * All plugin run in the same WASM VM, like the Lua plugin in the Lua VM | ||
| * Each plugin has its own VMContext (the root ctx) | ||
| * Each configured route/global rules has its own PluginContext (the plugin ctx). |
Contributor
There was a problem hiding this comment.
Suggested change
| * Each configured route/global rules has its own PluginContext (the plugin ctx). | |
| * Each configured route/global rules has its own PluginContext (the plugin ctx). | |
Member
Author
There was a problem hiding this comment.
The For example in the next line belongs to this item.
| * All plugin run in the same WASM VM, like the Lua plugin in the Lua VM | ||
| * Each plugin has its own VMContext (the root ctx) | ||
| * Each configured route/global rules has its own PluginContext (the plugin ctx). | ||
| For example, if we have a service configures with WASM plugin, and two routes inherit from it, |
Contributor
There was a problem hiding this comment.
Suggested change
| For example, if we have a service configures with WASM plugin, and two routes inherit from it, | |
| For example, if we have a service configuring the WASM plugin, and two routes inherit from it, |
| there will be two plugin ctxs. | ||
| * Each HTTP request which hits the configuration will have its own HttpContext (the HTTP ctx). | ||
| For example, if we configure both global rules and route, the HTTP request will | ||
| have two HTTP ctxs, one for the plugin ctx from global rules and another for the |
Contributor
There was a problem hiding this comment.
Suggested change
| have two HTTP ctxs, one for the plugin ctx from global rules and another for the | |
| have two HTTP ctxs, one for the plugin ctx from global rules and the other for the |
membphis
reviewed
Oct 20, 2021
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
A benchmark is missing, confirm that it works
| type = "object", | ||
| properties = { | ||
| name = { | ||
| type = "string" |
Member
There was a problem hiding this comment.
Lack of a reasonable length range?
Member
Author
There was a problem hiding this comment.
We don't need to have a limitation of the length. Otherwise people will ask they can't set a xxx with length yyy.
| type = "string" | ||
| }, | ||
| file = { | ||
| type = "string" |
| function get_plugin_ctx_key(ctx) | ||
| key_buf[1] = ctx.conf_type | ||
| key_buf[2] = ctx.conf_id | ||
| return concat(key_buf, "#", 1, 2) |
Member
There was a problem hiding this comment.
style: ctx.conf_type .. '#' .. ctx.conf_id is better
Member
Author
There was a problem hiding this comment.
The current way is faster
| └────────────────────────────────────────────────────────────────┘ | ||
| ``` | ||
|
|
||
| * All plugin run in the same WASM VM, like the Lua plugin in the Lua VM |
Member
Author
I will add it later, this PR already has more than 1000 lines. |
Signed-off-by: spacewander <[email protected]>
Member
Author
Xunzhuo
reviewed
Oct 21, 2021
Comment on lines
+26
to
+27
| This plugin requires APISIX to run on [APISIX-OpenResty](../how-to-build.md#step-6-build-openresty-for-apache-apisix), and is under construction. | ||
| Currently, only a few APIs are implemented. Please follow [wasm-nginx-module](https://github.com/api7/wasm-nginx-module) to know the progress. |
Contributor
There was a problem hiding this comment.
and is under construction -> which is under construction
Member
Author
There was a problem hiding this comment.
No, after this change it seems APISIX-OpenResty is under construction.
nic-chen
reviewed
Oct 22, 2021
tokers
approved these changes
Oct 22, 2021
nic-chen
approved these changes
Oct 22, 2021
shuaijinchao
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Fix #157
Pre-submission checklist: