Skip to content

feat(control): expose services#5271

Merged
spacewander merged 6 commits into
apache:masterfrom
bisakhmondal:control_api_services
Oct 20, 2021
Merged

feat(control): expose services#5271
spacewander merged 6 commits into
apache:masterfrom
bisakhmondal:control_api_services

Conversation

@bisakhmondal

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR exposes 2 control API routes for

  1. All services
  2. Service with a particular service_id

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bisakhmondal

Copy link
Copy Markdown
Member Author

cc @spacewander for a review. Thanks : )

Comment thread t/control/services.t
=== TEST 1: services
--- apisix_yaml
services:
-

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test with multiple services

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@spacewander spacewander changed the title feat: expose services via control API feat(control): expose services Oct 20, 2021
@spacewander
spacewander merged commit e68e03f into apache:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants