feat(control): add dump upstream api#5259
Merged
Merged
Conversation
Contributor
Author
|
cc @spacewander , would you like to take a look at this? |
Xunzhuo
marked this pull request as ready for review
October 18, 2021 10:07
spacewander
reviewed
Oct 18, 2021
spacewander
reviewed
Oct 19, 2021
spacewander
approved these changes
Oct 19, 2021
juzhiyuan
approved these changes
Oct 19, 2021
| local upstream_id = uri_segs[4] | ||
| local upstream = iter_add_get_upstream_info(upstreams, upstream_id) | ||
| if not upstream then | ||
| return 404, {error_msg = str_format("upstream[%s] not found", upstream_id)} |
Member
There was a problem hiding this comment.
Do we need a space like upstream [%s]?
Contributor
Author
There was a problem hiding this comment.
If this will be changed, the error msg from dump routes should be changed in this format too, so in my view, this is OK for me 😃
spacewander
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feat: add dump upstream api in control api
/v1/upstreamsupstream_idwith/v1/upstream/{upstream_id}Pre-submission checklist: