feat: support specify custom sni in etcd conf#5206
Merged
Conversation
Signed-off-by: tzssangglass <[email protected]>
tokers
reviewed
Oct 12, 2021
Signed-off-by: tzssangglass <[email protected]>
spacewander
reviewed
Oct 12, 2021
� Conflicts: � t/cli/test_etcd_mtls.sh
Signed-off-by: tzssangglass <[email protected]>
Signed-off-by: tzssangglass <[email protected]>
spacewander
approved these changes
Oct 13, 2021
|
|
||
| verify: true # whether to verify the etcd endpoint certificate when setup a TLS connection to etcd, | ||
| # the default value is true, e.g. the certificate will be verified strictly. | ||
| #sni: # the SNI fot etcd TLS requests |
Member
There was a problem hiding this comment.
Suggested change
| #sni: # the SNI fot etcd TLS requests | |
| #sni: # the SNI for etcd TLS requests. If missed, the host part of the URL will be used |
Signed-off-by: tzssangglass <[email protected]>
Signed-off-by: tzssangglass <[email protected]>
tokers
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tzssangglass [email protected]
What this PR does / why we need it:
fix: #5155
Pre-submission checklist: