Skip to content

feat: allow route to inherit hosts from service#4977

Merged
spacewander merged 2 commits into
apache:masterfrom
spacewander:shh
Sep 6, 2021
Merged

feat: allow route to inherit hosts from service#4977
spacewander merged 2 commits into
apache:masterfrom
spacewander:shh

Conversation

@spacewander

Copy link
Copy Markdown
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander marked this pull request as ready for review September 3, 2021 04:02
Comment thread t/router/radixtree-host-uri2.t
Comment thread t/router/radixtree-host-uri3.t Outdated
Signed-off-by: spacewander <[email protected]>
@spacewander
spacewander merged commit 0ba89d5 into apache:master Sep 6, 2021
@spacewander
spacewander deleted the shh branch September 6, 2021 00:57
@Donghui0

Copy link
Copy Markdown
Contributor

in plugin.merge_service_route function, need to add processing for route.value.timeout. Otherwise, the timeout attribute of ApisixRoute will be invalid.

I have a question in the merge service_route method. Why not directly core.table.deepcopy(route_conf), assign the attribute of service to new_conf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants