Skip to content

feat(limit-*): add custom reject-message for traffic control#4808

Merged
spacewander merged 10 commits into
apache:masterfrom
okaybase:return-value
Aug 13, 2021
Merged

feat(limit-*): add custom reject-message for traffic control#4808
spacewander merged 10 commits into
apache:masterfrom
okaybase:return-value

Conversation

@okaybase

@okaybase okaybase commented Aug 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Add custom reject-message for traffic control, service provider can tell the caller what happens.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

spacewander
spacewander reviewed Aug 12, 2021
View reviewed changes
Comment thread t/plugin/limit-conn.t Outdated
Comment thread docs/zh/latest/plugins/limit-conn.md Outdated
Comment thread docs/en/latest/plugins/limit-req.md Outdated
Comment thread apisix/plugins/limit-conn/init.lua Outdated
Comment thread t/plugin/limit-count-redis-cluster.t Outdated
Comment thread t/plugin/limit-count-redis-cluster.t Outdated
@okaybase
okaybase requested a review from spacewander August 12, 2021 07:44
spacewander
spacewander reviewed Aug 12, 2021
View reviewed changes
Comment thread t/plugin/limit-count.t Outdated
Comment thread t/plugin/limit-conn2.t Outdated
Comment thread t/plugin/limit-count.t Outdated
@okaybase
okaybase requested a review from spacewander August 12, 2021 14:09
tzssangglass
tzssangglass reviewed Aug 12, 2021
View reviewed changes
Comment thread docs/en/latest/plugins/limit-conn.md Outdated
Comment thread docs/zh/latest/plugins/limit-conn.md Outdated
@tzssangglass

tzssangglass commented Aug 12, 2021

Copy link
Copy Markdown
Member

@spacewander I think we need to unify the rejected_code and rejected_msg attributes of the limit-req, limit-conn and limit-count.

At present they look somewhat incongruous.

@okaybase
okaybase requested a review from tzssangglass August 12, 2021 15:33
spacewander
spacewander reviewed Aug 13, 2021
View reviewed changes
Comment thread t/plugin/limit-count2.t Outdated
@okaybase
okaybase requested a review from spacewander August 13, 2021 02:52
@spacewander spacewander changed the title feat(plugin): add custom reject-message for traffic control feat(limit-*): add custom reject-message for traffic control Aug 13, 2021
@spacewander
spacewander merged commit b7cbaed into apache:master Aug 13, 2021
@okaybase
okaybase deleted the return-value branch August 13, 2021 03:06
@liuxiran liuxiran mentioned this pull request Aug 26, 2021
Closed
@spacewander spacewander mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes
@tzssangglass tzssangglass tzssangglass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okaybase @tzssangglass @spacewander